Switch profiler from isolates to threads

runtime/vm/isolate.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ISOLATE_H_
 #define VM_ISOLATE_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/atomic.h"
@@ skipping 136 matching lines @@
 
   // Limited public access to BaseIsolate::mutator_thread_ for code that
   // must treat the mutator as the default or a special case. Prefer code
   // that works uniformly across all threads.
   bool HasMutatorThread() {
     return mutator_thread_ != NULL;
   }
   bool MutatorThreadIsCurrentThread() {
     return mutator_thread_ == Thread::Current();
   }
+  bool IsMutatorThread(Thread* thread) {
+    ASSERT(thread != NULL);
+    return mutator_thread_ == thread;
+  }

[siva, 2015/10/26 23:45:26]

Both these functions
  MutatorThreadIsCurrentThread
  IsMutatorThread
should be removed from here and we should have a function in Thread
  IsMutatorThread

(I have submitted a cl that cleans up MutatorThreadIsCurrentThread() and added a
IsMutatorThread method in the thread).

[Cutch, 2015/10/27 22:36:24]

I've switched to using thread->IsMutatorThread() and removed 'IsMutatorThread'
from my CL.

 
   const char* name() const { return name_; }
   const char* debugger_name() const { return debugger_name_; }
   void set_debugger_name(const char* name);
 
   int64_t start_time() const { return start_time_; }
 
   Dart_Port main_port() const { return main_port_; }
   void set_main_port(Dart_Port port) {
     ASSERT(main_port_ == 0);  // Only set main port once.
@@ skipping 153 matching lines @@
   void set_message_handler(MessageHandler* value) { message_handler_ = value; }
 
   bool is_runnable() const { return is_runnable_; }
   void set_is_runnable(bool value) { is_runnable_ = value; }
 
   IsolateSpawnState* spawn_state() const { return spawn_state_; }
   void set_spawn_state(IsolateSpawnState* value) { spawn_state_ = value; }
 
   Mutex* mutex() const { return mutex_; }
 
+  bool HasDebugger() const {
+    return debugger_ != NULL;
+  }
+
   Debugger* debugger() const {
     ASSERT(debugger_ != NULL);
     return debugger_;
   }
 
   void set_single_step(bool value) { single_step_ = value; }
   bool single_step() const { return single_step_; }
   static intptr_t single_step_offset() {
     return OFFSET_OF(Isolate, single_step_);
   }
@@ skipping 223 matching lines @@
   intptr_t UnblockClassFinalization() {
     ASSERT(defer_finalization_count_ > 0);
     return defer_finalization_count_--;
   }
 
   bool AllowClassFinalization() {
     ASSERT(defer_finalization_count_ >= 0);
     return defer_finalization_count_ == 0;
   }
 
-  Mutex* profiler_data_mutex() {
-    return &profiler_data_mutex_;
-  }
-
-  void set_profiler_data(IsolateProfilerData* profiler_data) {
-    profiler_data_ = profiler_data;
-  }
-
-  IsolateProfilerData* profiler_data() const {
-    return profiler_data_;
-  }
-
   void PrintJSON(JSONStream* stream, bool ref = true);
 
   CompilerStats* compiler_stats() {
     return compiler_stats_;
   }
 
-  // Returns the number of sampled threads.
-  intptr_t ProfileInterrupt();
-
   VMTagCounters* vm_tag_counters() {
     return &vm_tag_counters_;
   }
 
   uword user_tag() const {
     return user_tag_;
   }
   static intptr_t user_tag_offset() {
     return OFFSET_OF(Isolate, user_tag_);
   }
@@ skipping 202 matching lines @@
   // Timestamps of last operation via service.
   int64_t last_allocationprofile_accumulator_reset_timestamp_;
   int64_t last_allocationprofile_gc_timestamp_;
 
   // Ring buffer of objects assigned an id.
   ObjectIdRing* object_id_ring_;
 
   // Trace buffer support.
   TraceBuffer* trace_buffer_;
 
-  IsolateProfilerData* profiler_data_;
-  Mutex profiler_data_mutex_;
-
   VMTagCounters vm_tag_counters_;
   RawGrowableObjectArray* tag_table_;
 
   RawGrowableObjectArray* deoptimized_code_array_;
 
   // Background compilation.
   BackgroundCompiler* background_compiler_;
   RawGrowableObjectArray* background_compilation_queue_;
 
   // We use 6 list entries for each pending service extension calls.
@@ skipping 216 matching lines @@
   uint8_t* serialized_message_;
   intptr_t serialized_message_len_;
   Isolate::Flags isolate_flags_;
   bool paused_;
   bool errors_are_fatal_;
 };
 
 }  // namespace dart
 
 #endif  // VM_ISOLATE_H_