Switch profiler from isolates to threads

runtime/vm/dart.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/dart.h"
 
 #include "vm/code_observers.h"
 #include "vm/cpu.h"
 #include "vm/dart_api_state.h"
 #include "vm/dart_entry.h"
@@ skipping 279 matching lines @@
   tds.CopyArgument(0, "isolateName", I->name());
 
   ASSERT(I != NULL);
   StackZone zone(T);
   HandleScope handle_scope(T);
   {
     TimelineDurationScope tds(T, I->GetIsolateStream(), "ObjectStore::Init");
     ObjectStore::Init(I);
   }
 
-  // Setup for profiling.
-  Profiler::InitProfilingForIsolate(I);

[Ivan Posva, 2015/10/28 08:27:47]

There is no equivalent needed because the fact that this thread is associated
with an isolate makes it profilable, correct?

How do we ensure that the profiler is ticking though?

[Cutch, 2015/10/28 14:39:18]

Correct.
I'm doing a pass now to ensure that the profiler is ticking threads and stops
ticking when a thread exists an isolate.

-
   const Error& error = Error::Handle(Object::Init(I));
   if (!error.IsNull()) {
     return error.raw();
   }
   if (snapshot_buffer != NULL) {
     // Read the snapshot and setup the initial state.
     TimelineDurationScope tds(
         T, I->GetIsolateStream(), "IsolateSnapshotReader");
     // TODO(turnidge): Remove once length is not part of the snapshot.
     const Snapshot* snapshot = Snapshot::SetupFromBuffer(snapshot_buffer);
@@ skipping 110 matching lines @@
   return predefined_handles_->handles_.IsValidScopedHandle(address);
 }
 
 
 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) {
   ASSERT(predefined_handles_ != NULL);
   return predefined_handles_->api_handles_.IsValidHandle(handle);
 }
 
 }  // namespace dart