Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1412733006: Fold IPCSupportInitializer::ForceShutdown() with ShutDown(). (Closed)

Created:
5 years, 2 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fold IPCSupportInitializer::ForceShutdown() with ShutDown(). A race is possible on browser shut down where the UI thread releases its last |ScopedIPCSupport| which then causes ShutDown() to call ForceShutdown() since the last reference is released. However, at the point ForceShutdown() is called, |lock_| is not held and so a utility process being created on the IO thead can call Init() and assume it has a reference to the IPC support. However, |shutting_down_| hasn't been set yet, so there's no way to cancel the shutdown process. This causes |ChannelManager| internally to post a task to the IO thread with a reference to itself, even though it is about to be destroyed. BUG=542069 Committed: https://crrev.com/55eeeffd666bd30f20bf596f117ea1a101d4b202 Cr-Commit-Position: refs/heads/master@{#354924}

Patch Set 1 #

Patch Set 2 : Add myself and Ken to owners. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -22 lines) Patch
M ipc/mojo/OWNERS View 1 1 chunk +3 lines, -1 line 0 comments Download
M ipc/mojo/scoped_ipc_support.cc View 4 chunks +10 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Anand Mistry (off Chromium)
5 years, 2 months ago (2015-10-19 02:58:27 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 2 months ago (2015-10-19 21:54:46 UTC) #3
Anand Mistry (off Chromium)
jam@chromium.org: Because OWNERS.
5 years, 2 months ago (2015-10-19 22:02:23 UTC) #5
jam
On 2015/10/19 22:02:23, Anand Mistry wrote: > mailto:jam@chromium.org: Because OWNERS. Anand: can you add yourself ...
5 years, 2 months ago (2015-10-19 22:54:31 UTC) #6
Anand Mistry (off Chromium)
On 2015/10/19 22:54:31, jam wrote: > On 2015/10/19 22:02:23, Anand Mistry wrote: > > mailto:jam@chromium.org: ...
5 years, 2 months ago (2015-10-19 23:04:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412733006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412733006/20001
5 years, 2 months ago (2015-10-19 23:13:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-20 00:13:23 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 00:14:38 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55eeeffd666bd30f20bf596f117ea1a101d4b202
Cr-Commit-Position: refs/heads/master@{#354924}

Powered by Google App Engine
This is Rietveld 408576698