Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 1412733002: C++ bindings: separate out serialization source set, have "mojom" targets optionally use serializat… (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: remove unused --cpp_dataonly flag Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/mojom.gni
diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni
index 0c0f294c5c5d5ad5ca8a7b08e48a52dae8f155a2..6b0ad4ae5fd09b02975f9dc75a7c57deac3f644e 100644
--- a/mojo/public/tools/bindings/mojom.gni
+++ b/mojo/public/tools/bindings/mojom.gni
@@ -191,6 +191,10 @@ template("mojom") {
rebase_path(root_gen_dir),
]
+ if (defined(invoker.dataonly) && invoker.dataonly) {
+ args += [ "--cpp_dataonly" ]
+ }
+
if (defined(invoker.import_dirs)) {
foreach(import_dir, invoker.import_dirs) {
args += [
@@ -216,7 +220,14 @@ template("mojom") {
public_configs =
rebase_path([ "mojo/public/build/config:mojo_sdk" ], ".", mojo_root)
- public_deps = rebase_path([ "mojo/public/cpp/bindings" ], ".", mojo_root)
+ if (defined(invoker.dataonly) && invoker.dataonly) {
+ public_deps = rebase_path([ "mojo/public/cpp/bindings:serialization" ],
+ ".",
+ mojo_root)
+ } else {
+ public_deps = rebase_path([ "mojo/public/cpp/bindings" ], ".", mojo_root)
+ }
+
if (defined(invoker.sources)) {
public_deps += [ ":${cpp_sources_target_name}" ]
}

Powered by Google App Engine
This is Rietveld 408576698