mojo/PRESUBMIT.py - Issue 1412733002: C++ bindings: separate out serialization source set, have "mojom" targets optionally use serializat…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/PRESUBMIT.py

Issue 1412733002: C++ bindings: separate out serialization source set, have "mojom" targets optionally use serializat… (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: address comments from previous patch Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/PRESUBMIT.py

diff --git a/mojo/PRESUBMIT.py b/mojo/PRESUBMIT.py

index e770e481449ff3ced9de1e60c78e1e4f15de8c2c..0a6429502b4f9b1cf9d4569b1b06d94f8dac689a 100644

--- a/mojo/PRESUBMIT.py

+++ b/mojo/PRESUBMIT.py

@@ -193,6 +193,8 @@ def _CheckSourceSetsAreOfCorrectType(input_api, output_api, package):

problems = []

for f in _AffectedBuildFilesWithinPackage(input_api, package):

+ if f.LocalPath() == "mojo/public/tools/bindings/mojom.gni":

+ continue

for line_num, line in f.ChangedContents():

m = re.search(r"[a-z_]*source_set\(", line)

if not m:

« no previous file with comments | « examples/serialization/serialization.mojom ('k') | mojo/public/cpp/bindings/BUILD.gn » ('j') | no next file with comments »