mojo/public/cpp/bindings/lib/array_serialization.h - Issue 1412733002: C++ bindings: separate out serialization source set, have "mojom" targets optionally use serializat…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/array_serialization.h

Issue 1412733002: C++ bindings: separate out serialization source set, have "mojom" targets optionally use serializat… (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: link sanitizer to examples/serialization (to fix the ASAN build failure) Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/BUILD.gn ('K') | « mojo/public/cpp/bindings/interface_request.h ('k') | mojo/public/cpp/bindings/lib/bindings_serialization.h » ('j') | mojo/public/tools/bindings/mojom.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/lib/array_serialization.h

diff --git a/mojo/public/cpp/bindings/lib/array_serialization.h b/mojo/public/cpp/bindings/lib/array_serialization.h

index fbfdd613d37dc73b912159f946553d1afdb2cce3..a3cf85068309f0103b0821bbb36655b39cc5dd2e 100644

--- a/mojo/public/cpp/bindings/lib/array_serialization.h

+++ b/mojo/public/cpp/bindings/lib/array_serialization.h

@@ -17,7 +17,6 @@

#include <vector>

#include "mojo/public/c/system/macros.h"

-#include "mojo/public/cpp/bindings/interface_request.h"

#include "mojo/public/cpp/bindings/lib/array_internal.h"

#include "mojo/public/cpp/bindings/lib/bindings_internal.h"

#include "mojo/public/cpp/bindings/lib/iterator_util.h"

@@ -27,6 +26,10 @@

#include "mojo/public/cpp/bindings/lib/validation_errors.h"

namespace mojo {

+template <typename Interface>

+InterfaceRequest<Interface> MakeRequest(ScopedMessagePipeHandle handle);

namespace internal {

// The ArraySerializer template contains static methods for serializing |Array|s