C++ bindings: separate out serialization source set, have "mojom" targets optionally use serializat…

mojo/public/tools/bindings/mojom.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("../../mojo_sdk.gni")
 
 # Generate C++/JavaScript/Java/Python/Dart/Go source files from mojom files. The
 # output files will go under the generated file directory tree with the same
 # path as each input file.
 #
@@ skipping 184 matching lines @@
         foreach(import_dir, invoker.import_dirs) {
           args += [
             "-I",
             rebase_path(import_dir, root_build_dir),
           ]
         }
       }
     }
   }
 
+  # Some re-usable variables for the C++ source sets:
+  cpp_public_deps = []
+  if (defined(invoker.sources)) {
+    cpp_public_deps += [ ":${cpp_sources_target_name}" ]
+  }
+  cpp_public_deps += rebased_mojo_sdk_public_deps
+  if (defined(invoker.public_deps)) {
+    cpp_public_deps += invoker.public_deps
+  }
+  if (defined(invoker.sources)) {
+    cpp_public_deps += [ ":$generator_target_name" ]
+  }
+  cpp_deps = []
+  cpp_deps += rebased_mojo_sdk_deps

[jamesr, 2015/10/21 00:24:56]

= []
+= ...

isn't needed, you can just say

cpp_deps = rebased_mojo_sdk_deps

the = [] then append pattern is useful if the variable declaration is separated
from uses or conditional branches

[vardhan, 2015/10/21 19:29:38]

Done.

+  if (defined(invoker.deps)) {
+    cpp_deps += invoker.deps
+  }
+  if (defined(invoker.mojo_sdk_deps)) {
+    foreach(sdk_dep, invoker.mojo_sdk_deps) {
+      # Check that the SDK dep was not mistakenly given as an absolute path.
+      assert(get_path_info(sdk_dep, "abspath") != sdk_dep)
+      cpp_deps += [ rebase_path(sdk_dep, ".", mojo_root) ]
+    }
+  }
+
   source_set(target_name) {
     if (defined(invoker.visibility)) {
       visibility = invoker.visibility
     }
     if (defined(invoker.testonly)) {
       testonly = invoker.testonly
     }
     if (defined(invoker.sources)) {
       data = process_file_template(invoker.sources, generator_js_outputs)
     }
 
     public_configs =
         rebase_path([ "mojo/public/build/config:mojo_sdk" ], ".", mojo_root)
 
     public_deps = rebase_path([ "mojo/public/cpp/bindings" ], ".", mojo_root)
+    public_deps += cpp_public_deps
+
+    deps = cpp_deps
+  }
+
+  source_set("${target_name}_dataonly") {

[viettrungluu, 2015/10/20 23:54:37]

Maybe "_data_only" would look nicer?

[jamesr, 2015/10/21 00:24:56]

+1

[vardhan, 2015/10/21 19:29:38]

Done.

+    if (defined(invoker.visibility)) {
+      visibility = invoker.visibility
+    }
+    if (defined(invoker.testonly)) {
+      testonly = invoker.testonly
+    }
     if (defined(invoker.sources)) {
-      public_deps += [ ":${cpp_sources_target_name}" ]
-    }
-    public_deps += rebased_mojo_sdk_public_deps
-    if (defined(invoker.public_deps)) {
-      public_deps += invoker.public_deps
+      data = process_file_template(invoker.sources, generator_js_outputs)
     }
 
-    deps = []
-    if (defined(invoker.sources)) {
-      public_deps += [ ":$generator_target_name" ]
-    }
-    deps += rebased_mojo_sdk_deps
-    if (defined(invoker.deps)) {
-      deps += invoker.deps
-    }
-    if (defined(invoker.mojo_sdk_deps)) {
-      foreach(sdk_dep, invoker.mojo_sdk_deps) {
-        # Check that the SDK dep was not mistakenly given as an absolute path.
-        assert(get_path_info(sdk_dep, "abspath") != sdk_dep)
-        deps += [ rebase_path(sdk_dep, ".", mojo_root) ]
-      }
-    }
+    public_configs =
+        rebase_path([ "mojo/public/build/config:mojo_sdk" ], ".", mojo_root)
+
+    public_deps = rebase_path([ "mojo/public/cpp/bindings:serialization" ],
+                              ".",
+                              mojo_root)
+    public_deps += cpp_public_deps
+    deps = cpp_deps
   }
 
   all_deps = rebased_mojo_sdk_deps + rebased_mojo_sdk_public_deps
   if (defined(invoker.deps)) {
     all_deps += invoker.deps
   }
   if (defined(invoker.public_deps)) {
     all_deps += invoker.public_deps
   }
 
@@ skipping 120 matching lines @@
         # //mojo/something:something and we can append "_java" to get the java
         # dependency name.
         full_name = get_label_info(d, "label_no_toolchain")
         deps += [ "${full_name}_java" ]
       }
 
       srcjar_deps = [ ":$java_srcjar_target_name" ]
     }
   }
 }