examples/serialization/serialization.mojom - Issue 1412733002: C++ bindings: separate out serialization source set, have "mojom" targets optionally use serializat…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: examples/serialization/serialization.mojom

Issue 1412733002: C++ bindings: separate out serialization source set, have "mojom" targets optionally use serializat… (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: link sanitizer to examples/serialization (to fix the ASAN build failure) Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be found

3 // found in the LICENSE file.	3 // in the LICENSE file.

4	4

5 module mojo.test;	5 module mojo.examples;
	viettrungluu 2015/10/20 23:54:37 I don't think you need to put this in the mojo mod I don't think you need to put this in the mojo module. (Or even in the examples module, for that matter.) vardhan 2015/10/21 19:29:38 All the examples I checked (echo, device_name, ind Show quoted text On 2015/10/20 at 23:54:37, viettrungluu wrote: > I don't think you need to put this in the mojo module. > > (Or even in the examples module, for that matter.) All the examples I checked (echo, device_name, indirect_service, keyboard_client) are atleast in an examples {} namespace. Any reason why this should be in global namespace vs. example? (I'll move it out of the mojo namespace though)
6	6

7 union IncludedUnion {	7 struct MyStruct {

8 int8 a;	8 int32 a;

	9 float b;

	10 string c;

9 };	11 };

OLD	NEW

« examples/serialization/main.cc ('K') | « examples/serialization/main.cc ('k') | mojo/PRESUBMIT.py » ('j') | mojo/PRESUBMIT.py » ('J')