Play automatically when reloading the audio player with new songs.

Play automatically when reloading the audio player with new songs.

Because of introducing an async call during initialization, the new appstate was being changed. Playing a song adds a 'time' field to the appstate. Having a time field causes pausing the audio player once the initialization is finished.

To avoid this, a copy is made, to avoid altering the input 'playlist' object.

TEST=Tested manually. Partly browser tests.
BUG=335422
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245493

[mtomasz, 2014-01-17 04:06:03]

@hirono: PTAL. Thanks!

[hirono, 2014-01-17 05:12:12]

lgtm with a nit.

https://codereview.chromium.org/141273004/diff/1/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/foreground/js/media/audio_player.js
(right):

https://codereview.chromium.org/141273004/diff/1/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/foreground/js/media/audio_player.js:76:
AudioPlayer.instance.load(window.appState);
Can we keep the line as reload() since the reload function is updated?

[mtomasz, 2014-01-17 05:14:30]

https://codereview.chromium.org/141273004/diff/1/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/foreground/js/media/audio_player.js
(right):

https://codereview.chromium.org/141273004/diff/1/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/foreground/js/media/audio_player.js:76:
AudioPlayer.instance.load(window.appState);
On 2014/01/17 05:12:12, hirono wrote:
> Can we keep the line as reload() since the reload function is updated?

What do you mean? Can you clarify, please?

[hirono, 2014-01-17 05:18:48]

https://codereview.chromium.org/141273004/diff/1/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/foreground/js/media/audio_player.js
(right):

https://codereview.chromium.org/141273004/diff/1/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/foreground/js/media/audio_player.js:76:
AudioPlayer.instance.load(window.appState);
On 2014/01/17 05:14:30, mtomasz wrote:
> On 2014/01/17 05:12:12, hirono wrote:
> > Can we keep the line as reload() since the reload function is updated?
> 
> What do you mean? Can you clarify, please?

This CL replaces "reload()" with "AudioPlayer.instance.load(...)", but the
implementation of realod function is also changed as well. So we don't need to
change the line.

[mtomasz, 2014-01-17 05:27:42]

https://codereview.chromium.org/141273004/diff/1/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/foreground/js/media/audio_player.js
(right):

https://codereview.chromium.org/141273004/diff/1/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/foreground/js/media/audio_player.js:76:
AudioPlayer.instance.load(window.appState);
On 2014/01/17 05:18:48, hirono wrote:
> On 2014/01/17 05:14:30, mtomasz wrote:
> > On 2014/01/17 05:12:12, hirono wrote:
> > > Can we keep the line as reload() since the reload function is updated?
> > 
> > What do you mean? Can you clarify, please?
> 
> This CL replaces "reload()" with "AudioPlayer.instance.load(...)", but the
> implementation of realod function is also changed as well. So we don't need to
> change the line.

That's right, but I think it is spaghetti to call reload() from load(). That's
why I changed it. WDYT?

[hirono, 2014-01-17 05:32:27]

https://codereview.chromium.org/141273004/diff/1/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/foreground/js/media/audio_player.js
(right):

https://codereview.chromium.org/141273004/diff/1/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/foreground/js/media/audio_player.js:76:
AudioPlayer.instance.load(window.appState);
On 2014/01/17 05:27:42, mtomasz wrote:
> On 2014/01/17 05:18:48, hirono wrote:
> > On 2014/01/17 05:14:30, mtomasz wrote:
> > > On 2014/01/17 05:12:12, hirono wrote:
> > > > Can we keep the line as reload() since the reload function is updated?
> > > 
> > > What do you mean? Can you clarify, please?
> > 
> > This CL replaces "reload()" with "AudioPlayer.instance.load(...)", but the
> > implementation of realod function is also changed as well. So we don't need
to
> > change the line.
> 
> That's right, but I think it is spaghetti to call reload() from load(). That's
> why I changed it. WDYT?

I got it. Then lgtm!

[commit-bot: I haz the power, 2014-01-17 06:54:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/141273004/1

[commit-bot: I haz the power, 2014-01-17 10:41:10]

Change committed as 245493