Source/core/rendering/style/BasicShapes.cpp - Issue 141273002: Code problems detected by cppcheck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/BasicShapes.cpp

Issue 141273002: Code problems detected by cppcheck (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add a few more fixes Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/style/BasicShapes.cpp

diff --git a/Source/core/rendering/style/BasicShapes.cpp b/Source/core/rendering/style/BasicShapes.cpp

index 092f06e09f94760de2eb8fc853939c7eb453b6d4..ecff010c7263533d657eb695356ba86ac5b7e929 100644

--- a/Source/core/rendering/style/BasicShapes.cpp

+++ b/Source/core/rendering/style/BasicShapes.cpp

@@ -213,7 +213,7 @@ bool DeprecatedBasicShapeEllipse::operator==(const BasicShape& o) const

if (!isSameType(o))

return false;

const DeprecatedBasicShapeEllipse& other = toDeprecatedBasicShapeEllipse(o);

- return m_centerX == other.m_centerX && m_centerY == other.m_centerY && m_radiusX == other.m_radiusX && m_radiusY == m_radiusY;

+ return m_centerX == other.m_centerX && m_centerY == other.m_centerY && m_radiusX == other.m_radiusX && m_radiusY == other.m_radiusY;

Inactive 2014/01/17 00:54:53 Nice bug

abarth-chromium 2014/01/17 06:59:08 Can you write a test for this change?

}

PassRefPtr<BasicShape> DeprecatedBasicShapeEllipse::blend(const BasicShape* other, double progress) const