Source/core/loader/FrameLoader.cpp - Issue 141273002: Code problems detected by cppcheck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 141273002: Code problems detected by cppcheck (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add a few more fixes Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/FrameLoader.cpp

diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp

index 2c3844ca7adc7ec047ffe5092226ff41d1bb7f04..06bbce3a01c3016cfc61bb863ccc570c8d8bead5 100644

--- a/Source/core/loader/FrameLoader.cpp

+++ b/Source/core/loader/FrameLoader.cpp

@@ -1004,7 +1004,7 @@ void FrameLoader::detachChildren()

for (Frame* child = m_frame->tree().lastChild(); child; child = child->tree().previousSibling())

childrenToDetach.append(child);

FrameVector::iterator end = childrenToDetach.end();

- for (FrameVector::iterator it = childrenToDetach.begin(); it != end; it++)

+ for (FrameVector::iterator it = childrenToDetach.begin(); it != end; ++it)

(*it)->loader().detachFromParent();

}