Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: Source/platform/exported/WebHTTPLoadInfo.cpp

Issue 141273002: Code problems detected by cppcheck (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add a few more fixes Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 void WebHTTPLoadInfo::reset() 47 void WebHTTPLoadInfo::reset()
48 { 48 {
49 m_private.reset(); 49 m_private.reset();
50 } 50 }
51 51
52 void WebHTTPLoadInfo::assign(const WebHTTPLoadInfo& r) 52 void WebHTTPLoadInfo::assign(const WebHTTPLoadInfo& r)
53 { 53 {
54 m_private = r.m_private; 54 m_private = r.m_private;
55 } 55 }
56 56
57 WebHTTPLoadInfo::WebHTTPLoadInfo(WTF::PassRefPtr<WebCore::ResourceLoadInfo> valu e) 57 WebHTTPLoadInfo::WebHTTPLoadInfo(WTF::PassRefPtr<WebCore::ResourceLoadInfo> valu e) : m_private(value)
abarth-chromium 2014/01/17 06:59:08 The initializer should be on its own line.
58 { 58 {
59 m_private = value;
60 } 59 }
61 60
62 WebHTTPLoadInfo::operator WTF::PassRefPtr<WebCore::ResourceLoadInfo>() const 61 WebHTTPLoadInfo::operator WTF::PassRefPtr<WebCore::ResourceLoadInfo>() const
63 { 62 {
64 return m_private.get(); 63 return m_private.get();
65 } 64 }
66 65
67 int WebHTTPLoadInfo::httpStatusCode() const 66 int WebHTTPLoadInfo::httpStatusCode() const
68 { 67 {
69 ASSERT(!m_private.isNull()); 68 ASSERT(!m_private.isNull());
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 return m_private->responseHeadersText; 137 return m_private->responseHeadersText;
139 } 138 }
140 139
141 void WebHTTPLoadInfo::setResponseHeadersText(const WebString& headersText) 140 void WebHTTPLoadInfo::setResponseHeadersText(const WebString& headersText)
142 { 141 {
143 ASSERT(!m_private.isNull()); 142 ASSERT(!m_private.isNull());
144 m_private->responseHeadersText = headersText; 143 m_private->responseHeadersText = headersText;
145 } 144 }
146 145
147 } // namespace blink 146 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698