Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: Source/web/WebPopupMenuImpl.cpp

Issue 141273002: Code problems detected by cppcheck (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/platform/network/HTTPRequest.cpp ('k') | Source/wtf/text/WTFString.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 WebPopupMenu* WebPopupMenu::create(WebWidgetClient* client) 61 WebPopupMenu* WebPopupMenu::create(WebWidgetClient* client)
62 { 62 {
63 // Pass the WebPopupMenuImpl's self-reference to the caller. 63 // Pass the WebPopupMenuImpl's self-reference to the caller.
64 return adoptRef(new WebPopupMenuImpl(client)).leakRef(); 64 return adoptRef(new WebPopupMenuImpl(client)).leakRef();
65 } 65 }
66 66
67 // WebWidget ------------------------------------------------------------------ 67 // WebWidget ------------------------------------------------------------------
68 68
69 WebPopupMenuImpl::WebPopupMenuImpl(WebWidgetClient* client) 69 WebPopupMenuImpl::WebPopupMenuImpl(WebWidgetClient* client)
70 : m_client(client) 70 : m_client(client)
71 // Set to impossible point so we always get the first mouse position.
72 , m_lastMousePosition(WebPoint(-1, -1))
71 , m_widget(0) 73 , m_widget(0)
72 { 74 {
73 // Set to impossible point so we always get the first mouse position.
74 m_lastMousePosition = WebPoint(-1, -1);
75 } 75 }
76 76
77 WebPopupMenuImpl::~WebPopupMenuImpl() 77 WebPopupMenuImpl::~WebPopupMenuImpl()
78 { 78 {
79 if (m_widget) 79 if (m_widget)
80 m_widget->setClient(0); 80 m_widget->setClient(0);
81 } 81 }
82 82
83 void WebPopupMenuImpl::initialize(FramelessScrollView* widget, const WebRect& bo unds) 83 void WebPopupMenuImpl::initialize(FramelessScrollView* widget, const WebRect& bo unds)
84 { 84 {
(...skipping 303 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 ASSERT(widget == m_widget); 388 ASSERT(widget == m_widget);
389 if (m_widget) { 389 if (m_widget) {
390 m_widget->setClient(0); 390 m_widget->setClient(0);
391 m_widget = 0; 391 m_widget = 0;
392 } 392 }
393 if (m_client) 393 if (m_client)
394 m_client->closeWidgetSoon(); 394 m_client->closeWidgetSoon();
395 } 395 }
396 396
397 } // namespace blink 397 } // namespace blink
OLDNEW
« no previous file with comments | « Source/platform/network/HTTPRequest.cpp ('k') | Source/wtf/text/WTFString.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698