Reland 'Use FrameSelection::selectedText where possible.'

third_party/WebKit/Source/core/editing/FrameSelection.cpp

Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index 12020051c2364d2ad6ab5f0d3b508efe0b0f7bda..f270e07ad70fd8241d85a1227462a03469cdc269 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -857,6 +857,12 @@ void FrameSelection::selectAll()
     notifyLayoutObjectOfSelectionChange(UserTriggered);
 }
 
+void FrameSelection::setSelectionInTextFormControl(const VisibleSelection& selection, SetSelectionOptions options)
+{
+    setSelection(selection, options);

[yosin_UTC9, 2015/10/29 06:44:48]

FrameSelection::setSelection() and SelectionEditor::setWithoutValidation() calls
SelectionEdtior::adjustSelectionInComposedTreeTwice(). It waste time.
Can we avoid this?

One idea is
Introduce SetSelectionOptions::ForTextFormControl then

void FrameSelection::setSelection(...) 
{
  ...
  if (options & ForTextFormControl)
    m_selectionEditor->setSelectionInTextFormControl(selection);
  else
    m_selectionEditor->setSelection(selection);
}

void SelectionEditor::setSelectionInTextFormControl(const VisibleSelection&
selection)
{
  // Since, we know |selection| doesn't cross shadow boundaries
  m_selection = selection;
 
m_selectionInComposedTree.setWithoutValidation(toPositionInComposedTree(selection.base()),
toPositionInComposedTree(selection.extent());
}

I'm on the way to home from Sapporo. Just quick response.

+    m_selectionEditor->setWithoutValidation(selection.base(), selection.extent());
+}
+
 bool FrameSelection::setSelectedRange(Range* range, TextAffinity affinity, SelectionDirectionalMode directional, SetSelectionOptions options)
 {
     if (!range || !range->startContainer() || !range->endContainer())
@@ -1143,9 +1149,9 @@ String FrameSelection::selectedHTMLForClipboard() const
     return extractSelectedHTMLAlgorithm<EditingInComposedTreeStrategy>(*this);
 }
 
-String FrameSelection::selectedText() const
+String FrameSelection::selectedText(TextIteratorBehavior behavior) const
 {
-    return extractSelectedText(*this, TextIteratorDefaultBehavior);
+    return extractSelectedText(*this, behavior);
 }
 
 String FrameSelection::selectedTextForClipboard() const