third_party/WebKit/Source/core/editing/SelectionEditor.cpp - Issue 1412713003: Reland 'Use FrameSelection::selectedText where possible.'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionEditor.cpp

Issue 1412713003: Reland 'Use FrameSelection::selectedText where possible.' Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reimplement setSelectionInTextFormControl: use setSelection. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionEditor.cpp

diff --git a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

index 9d0301e960b6a43355d8d37deb993f9b19f3cf19..2598963aae56fff99285e92db93ce94f117d3f09 100644

--- a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

+++ b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

@@ -166,6 +166,12 @@ void SelectionEditor::setWithoutValidation(const Position& start, const Position

adjustVisibleSelectionInComposedTree();

}

+void SelectionEditor::setSelectionInTextFormControl(const Position& start, const Position& end)

+ m_selection.setWithoutValidation(start, end);

+ m_selectionInComposedTree.setWithoutValidation(toPositionInComposedTree(start), toPositionInComposedTree(end));

TextDirection SelectionEditor::directionOfEnclosingBlock()

{

return blink::directionOfEnclosingBlock(m_selection.extent());