Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1412703002: [turbofan] Stage --turbo-inlining behind --turbo flag. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Stage --turbo-inlining behind --turbo flag. This stages the general purpose inlining mechanism in TurboFan and also disables the remaining tests that still fail. We do this to get test coverage early and to avoid regressing inlining as we go along. R=bmeurer@chromium.org BUG=v8:4493 LOG=n Committed: https://crrev.com/e34c343d2ac62f249359fcec07497c6e1a5537b9 Cr-Commit-Position: refs/heads/master@{#31386}

Patch Set 1 #

Patch Set 2 : More on 64-bit. #

Patch Set 3 : More after rebase. #

Patch Set 4 : More for mozilla tests. #

Patch Set 5 : More after next rebase. #

Patch Set 6 : More on ARM. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M src/flag-definitions.h View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +7 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 5 1 chunk +18 lines, -0 lines 0 comments Download
M test/mozilla/mozilla.status View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M test/simdjs/simdjs.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M test/webkit/webkit.status View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Michael Starzinger
Not sure whether we should land this CL (that disables the 10 failing tests) or ...
5 years, 2 months ago (2015-10-16 16:09:28 UTC) #2
Benedikt Meurer
LGTM modulo test failures.
5 years, 2 months ago (2015-10-18 11:26:20 UTC) #3
Michael Starzinger
Benedikt: PTAL. Also it is too late for me to land this now, I am ...
5 years, 2 months ago (2015-10-19 18:14:57 UTC) #5
Benedikt Meurer
LGTM, thanks. Will land and check now.
5 years, 2 months ago (2015-10-20 03:52:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412703002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412703002/100001
5 years, 2 months ago (2015-10-20 03:52:33 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 2 months ago (2015-10-20 03:53:53 UTC) #9
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/e34c343d2ac62f249359fcec07497c6e1a5537b9 Cr-Commit-Position: refs/heads/master@{#31386}
5 years, 2 months ago (2015-10-20 03:54:20 UTC) #10
Michael Achenbach
5 years, 2 months ago (2015-10-20 07:14:38 UTC) #11
Message was sent while issue was closed.
On 2015/10/20 03:54:20, commit-bot: I haz the power wrote:
> Patchset 6 (id:??) landed as
> https://crrev.com/e34c343d2ac62f249359fcec07497c6e1a5537b9
> Cr-Commit-Position: refs/heads/master@{#31386}

FYI: octane with turbofan got sad after this:
Typescript-octane2.1(Score): TypeError: funcDecl.isIndexerMember is not a
function

Powered by Google App Engine
This is Rietveld 408576698