Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: src/interpreter/bytecodes.h

Issue 1412683011: [Interpreter] Enable assignments in expressions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Additional tests for conditional expressions. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecodes.h
diff --git a/src/interpreter/bytecodes.h b/src/interpreter/bytecodes.h
index 96e4c35d6fdad1e60e20bdc501847719f4e0b9fc..5bafb2eb22becc7a0580151a3bda39c7200efd3e 100644
--- a/src/interpreter/bytecodes.h
+++ b/src/interpreter/bytecodes.h
@@ -64,6 +64,9 @@ namespace interpreter {
V(Ldar, OperandType::kReg8) \
V(Star, OperandType::kReg8) \
\
+ /* Register-register transfers */ \
+ V(Mov, OperandType::kReg8, OperandType::kReg8) \
+ \
/* LoadIC operations */ \
V(LoadICSloppy, OperandType::kReg8, OperandType::kIdx8, OperandType::kIdx8) \
V(LoadICStrict, OperandType::kReg8, OperandType::kIdx8, OperandType::kIdx8) \
@@ -260,9 +263,7 @@ class Register {
bool operator!=(const Register& other) const {
return index() != other.index();
}
- bool operator<(const Register& other) const {
- return index() < other.index();
- }
+ bool operator<(const Register& other) const { return index_ < other.index_; }
rmcilroy 2015/11/03 14:17:52 Could you check why this is needed?
oth 2015/11/04 10:03:37 Restored. No longer needed, not sure where in the
bool operator<=(const Register& other) const {
return index() <= other.index();
}
@@ -270,9 +271,6 @@ class Register {
private:
static const int kIllegalIndex = kMaxInt;
- void* operator new(size_t size);
- void operator delete(void* p);
rmcilroy 2015/11/03 14:17:52 We could keep this by using index() in the contain
oth 2015/11/04 10:03:37 Put these back and went with index() in the contai
-
int index_;
};

Powered by Google App Engine
This is Rietveld 408576698