src/compiler/bytecode-graph-builder.cc - Issue 1412683011: [Interpreter] Enable assignments in expressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 1412683011: [Interpreter] Enable assignments in expressions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Additional tests for conditional expressions. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/bytecode-graph-builder.cc

diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc

index 5c81906a7e19bd664442c2e6e93a25902c03b8b9..809f062fc4b1af689f571104c46cf920b59f323b 100644

--- a/src/compiler/bytecode-graph-builder.cc

+++ b/src/compiler/bytecode-graph-builder.cc

@@ -256,6 +256,13 @@ void BytecodeGraphBuilder::VisitStar(

}

+void BytecodeGraphBuilder::VisitMov(

+ const interpreter::BytecodeArrayIterator& iterator) {

+ Node* value = environment()->LookupRegister(iterator.GetRegisterOperand(0));

+ environment()->BindRegister(iterator.GetRegisterOperand(1), value);

void BytecodeGraphBuilder::VisitLdaGlobalSloppy(

const interpreter::BytecodeArrayIterator& iterator) {

UNIMPLEMENTED();