Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1412683002: Add an experimental domain (Closed)

Created:
5 years, 2 months ago by Brian Wilkerson
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org, devoncarew
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Clean up registration #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
A pkg/analysis_server/lib/src/domain_experimental.dart View 1 chunk +51 lines, -0 lines 2 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Brian Wilkerson
We'll want this class even if we update the spec.
5 years, 2 months ago (2015-10-16 17:52:15 UTC) #2
Paul Berry
lgtm
5 years, 2 months ago (2015-10-16 18:15:46 UTC) #3
pquitslund
LGTM! https://codereview.chromium.org/1412683002/diff/20001/pkg/analysis_server/lib/src/domain_experimental.dart File pkg/analysis_server/lib/src/domain_experimental.dart (right): https://codereview.chromium.org/1412683002/diff/20001/pkg/analysis_server/lib/src/domain_experimental.dart#newcode7 pkg/analysis_server/lib/src/domain_experimental.dart:7: import 'dart:core' hide Resource; Every time I see ...
5 years, 2 months ago (2015-10-16 19:34:22 UTC) #4
Brian Wilkerson
Committed patchset #2 (id:20001) manually as 3825cf0cd45f367de7f4cde35acd124b0a256725 (presubmit successful).
5 years, 2 months ago (2015-10-16 19:56:17 UTC) #5
scheglov
https://codereview.chromium.org/1412683002/diff/20001/pkg/analysis_server/lib/src/domain_experimental.dart File pkg/analysis_server/lib/src/domain_experimental.dart (right): https://codereview.chromium.org/1412683002/diff/20001/pkg/analysis_server/lib/src/domain_experimental.dart#newcode7 pkg/analysis_server/lib/src/domain_experimental.dart:7: import 'dart:core' hide Resource; On 2015/10/16 19:34:22, pquitslund wrote: ...
5 years, 2 months ago (2015-10-16 20:08:50 UTC) #7
pquitslund
5 years, 2 months ago (2015-10-16 20:09:28 UTC) #8
Message was sent while issue was closed.
On 2015/10/16 20:08:50, scheglov wrote:
>
https://codereview.chromium.org/1412683002/diff/20001/pkg/analysis_server/lib...
> File pkg/analysis_server/lib/src/domain_experimental.dart (right):
> 
>
https://codereview.chromium.org/1412683002/diff/20001/pkg/analysis_server/lib...
> pkg/analysis_server/lib/src/domain_experimental.dart:7: import 'dart:core'
hide
> Resource;
> On 2015/10/16 19:34:22, pquitslund wrote:
> > Every time I see this I cry a little.
> 
> It'll go soon.
> 
> /**
>  * DEPRECATED. A resource that can be read into the program.
>  *
>  * WARNING: This API is _deprecated_,
>  * and it will be removed in 1.14. Please use
>  * https://pub.dartlang.org/packages/resource instead.
>  *
>  * A resource is data that can be located using a URI and read into
>  * the program at runtime.
>  * The URI may use the `package` scheme to read resources provided
>  * along with package sources.
>  */
> @Deprecated('1.14')
> abstract class Resource {

\o/

Powered by Google App Engine
This is Rietveld 408576698