Introduce painted-device-scale-factor and use it when --enable-use-zoom-for-dsf is specified.

content/renderer/gpu/render_widget_compositor.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/gpu/render_widget_compositor.h"
 
 #include <limits>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 603 matching lines @@
     const WebSize& device_viewport_size) {
   layer_tree_host_->SetViewportSize(device_viewport_size);
 }
 
 WebFloatPoint RenderWidgetCompositor::adjustEventPointForPinchZoom(
     const WebFloatPoint& point) const {
   return point;
 }
 
 void RenderWidgetCompositor::setDeviceScaleFactor(float device_scale) {
-  layer_tree_host_->SetDeviceScaleFactor(device_scale);
+  if (IsUseZoomForDSFEnabled())
+    layer_tree_host_->SetPaintedDeviceScaleFactor(device_scale);

[danakj, 2015/10/22 23:15:29]

I think maybe you want a separate function in RWC and blink will call one or the
other

[oshima, 2015/10/23 18:05:36]

This is called from mulitple places, 

RenderWidgetFullscreenPepper
WebFrameWidgetImpl
WeebPagePopupImpl
WebViewImpl

and I felt this is a bit cleaner, especially the old path will be removed once
migration is done. I'll wait for the owners' suggestion.

[piman, 2015/10/23 19:30:33]

I kinda agree with Dana. WebViewImpl (and others) know what they are doing and
should tell RWC how to render / pass metadata, instead of RWC second-guessing
what they intend to do based on the flag (seems like a bit of a layering
violation).

[enne (OOO), 2015/10/23 21:21:25]

Agreed here as well.

[oshima, 2015/10/23 22:05:02]

How about letting WebWidgetClient set the device scale instead? I wanted Blink
not to know the mode. I think the way I changed WebViewImpl was mistake. I
should instead have had a method like WebViewImpl::setZoomFactorForDSF, and
remove enableUseZoomXxxx (I updated this part). This way, we can restrict the
mode knowledge in RenderWidget/RenderViewImpl.

What do you think?

[oshima, 2015/10/30 17:35:38]

This change wasn't actually necessary. I changed the following

* Add SetPaintedDeviceScaleFactor on RWC
* Let RenderViewImpl call RWC::SetPaintedDeviceScaleFactor. This is enough
because blink's dsf won't change.

I also removed the WebWidgetClient::deviceScaleFactor as it isn't necessary.

+  else
+    layer_tree_host_->SetDeviceScaleFactor(device_scale);
 }
 
 void RenderWidgetCompositor::setBackgroundColor(blink::WebColor color) {
   layer_tree_host_->set_background_color(color);
 }
 
 void RenderWidgetCompositor::setHasTransparentBackground(bool transparent) {
   layer_tree_host_->set_has_transparent_background(transparent);
 }
 
@@ skipping 445 matching lines @@
   // Ignore what the system said and give all clients the same maximum
   // allocation on desktop platforms.
   actual.bytes_limit_when_visible = 512 * 1024 * 1024;
   actual.priority_cutoff_when_visible =
       gpu::MemoryAllocation::CUTOFF_ALLOW_NICE_TO_HAVE;
 #endif
   return actual;
 }
 
 }  // namespace content