Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1412653005: Fix build_deb.sh script to work for any out directory, not only out/Release (Closed)

Created:
5 years, 1 month ago by Sergey Ulanov
Modified:
5 years, 1 month ago
Reviewers:
Lambros, Dirk Pranke
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build_deb.sh script to work for any output directory. Previously build_deb.sh was assuming that the build is in out/Release, which is not always correct, particularly with GN. BUG=512899 Committed: https://crrev.com/030286fd630303f825c46509ab85c2cb78067c11 Cr-Commit-Position: refs/heads/master@{#357658}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M remoting/host/installer/linux/Makefile View 1 chunk +3 lines, -1 line 0 comments Download
M remoting/host/installer/linux/build-deb.sh View 4 chunks +9 lines, -7 lines 0 comments Download
M remoting/remoting_host_linux.gypi View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sergey Ulanov
5 years, 1 month ago (2015-11-03 19:59:21 UTC) #3
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-03 21:12:12 UTC) #4
Lambros
lgtm
5 years, 1 month ago (2015-11-03 21:20:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412653005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412653005/1
5 years, 1 month ago (2015-11-03 21:57:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 22:40:52 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 22:42:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/030286fd630303f825c46509ab85c2cb78067c11
Cr-Commit-Position: refs/heads/master@{#357658}

Powered by Google App Engine
This is Rietveld 408576698