runtime/vm/compiler.cc - Issue 1412633007: Save the native name on the function instead of finding it in the token stream for lazily-linked na…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.cc

Issue 1412633007: Save the native name on the function instead of finding it in the token stream for lazily-linked na… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/compiler.cc

diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc

index 731699811a6446281dbc04293786c9b702ef7ae5..55b7161df316e79336fa2534092cc9e7b7cc6ad8 100644

--- a/runtime/vm/compiler.cc

+++ b/runtime/vm/compiler.cc

@@ -1138,7 +1138,7 @@ static RawError* CompileFunctionHelper(CompilationPipeline* pipeline,

// We got an error during compilation.

error = isolate->object_store()->sticky_error();

isolate->object_store()->clear_sticky_error();

- ASSERT(!optimized);

+ ASSERT(!optimized || Compiler::always_optimize());

srdjan 2015/11/09 23:17:32 Maybe add comment: precompilation can have errors.

rmacnak 2015/11/10 02:19:40 Added

// Do not attempt to optimize functions that can cause errors.

function.set_is_optimizable(false);

return error.raw();

« no previous file with comments | « no previous file | runtime/vm/native_entry.cc » ('j') | no next file with comments »