Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: runtime/vm/parser.cc

Issue 1412633007: Save the native name on the function instead of finding it in the token stream for lazily-linked na… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index ee1b60fe8313faa133a770b14f72a20f3058d33f..4ef954bbd812d818a3d17ca44da76a8b92049d79 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -3825,6 +3825,7 @@ void Parser::ParseMethodOrConstructor(ClassDesc* members, MemberDesc* method) {
}
intptr_t method_end_pos = TokenPos();
+ String* native_name = NULL;
if ((CurrentToken() == Token::kLBRACE) ||
(CurrentToken() == Token::kARROW)) {
if (method->has_abstract) {
@@ -3880,7 +3881,7 @@ void Parser::ParseMethodOrConstructor(ClassDesc* members, MemberDesc* method) {
ReportError(method->name_pos,
"Constructor with redirection may not have a function body");
}
- ParseNativeDeclaration();
+ native_name = &ParseNativeDeclaration();
method_end_pos = TokenPos();
ExpectSemicolon();
method->has_native = true;
@@ -3958,6 +3959,9 @@ void Parser::ParseMethodOrConstructor(ClassDesc* members, MemberDesc* method) {
if (method->metadata_pos > 0) {
library_.AddFunctionMetadata(func, method->metadata_pos);
}
+ if (method->has_native) {
+ func.set_native_name(*native_name);
+ }
// If this method is a redirecting factory, set the redirection information.
if (!redirection_type.IsNull()) {
@@ -5584,6 +5588,7 @@ void Parser::ParseTopLevelFunction(TopLevel* top_level,
intptr_t function_end_pos = function_pos;
bool is_native = false;
+ String* native_name = NULL;
if (is_external) {
function_end_pos = TokenPos();
ExpectSemicolon();
@@ -5603,7 +5608,7 @@ void Parser::ParseTopLevelFunction(TopLevel* top_level,
function_end_pos = TokenPos();
ExpectSemicolon();
} else if (IsSymbol(Symbols::Native())) {
- ParseNativeDeclaration();
+ native_name = &ParseNativeDeclaration();
function_end_pos = TokenPos();
ExpectSemicolon();
is_native = true;
@@ -5626,6 +5631,9 @@ void Parser::ParseTopLevelFunction(TopLevel* top_level,
if (library_.is_dart_scheme() && library_.IsPrivate(func_name)) {
func.set_is_reflectable(false);
}
+ if (is_native) {
+ func.set_native_name(*native_name);
+ }
AddFormalParamsToFunction(&params, func);
top_level->AddFunction(func);
if (!is_patch) {
@@ -5734,6 +5742,7 @@ void Parser::ParseTopLevelAccessor(TopLevel* top_level,
intptr_t accessor_end_pos = accessor_pos;
bool is_native = false;
+ String* native_name = NULL;
if (is_external) {
accessor_end_pos = TokenPos();
ExpectSemicolon();
@@ -5753,7 +5762,7 @@ void Parser::ParseTopLevelAccessor(TopLevel* top_level,
accessor_end_pos = TokenPos();
ExpectSemicolon();
} else if (IsSymbol(Symbols::Native())) {
- ParseNativeDeclaration();
+ native_name = &ParseNativeDeclaration();
accessor_end_pos = TokenPos();
ExpectSemicolon();
is_native = true;
@@ -5776,6 +5785,7 @@ void Parser::ParseTopLevelAccessor(TopLevel* top_level,
func.set_modifier(func_modifier);
if (is_native) {
func.set_is_debuggable(false);
+ func.set_native_name(*native_name);
}
if (library_.is_dart_scheme() && library_.IsPrivate(accessor_name)) {
func.set_is_reflectable(false);
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698