Save the native name on the function instead of finding it in the token stream for lazily-linked na…

Save the native name on the function instead of finding it in the token stream to resolve lazily-linked natives. Drop token streams from precompiled snapshots.

dart2js ARM -7.0% size

Before
VMIsolate(CodeSize): 4663679
Isolate(CodeSize): 11970519
Instructions(CodeSize): 12904384
Total(CodeSize): 29538582

After
VMIsolate(CodeSize): 2611555
Isolate(CodeSize): 11965825
Instructions(CodeSize): 12906464
Total(CodeSize): 27483844

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/8be0d4aca16feed4edded4d03b95723f7daa879f

[rmacnak, 2015-11-09 22:41:29]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[srdjan, 2015-11-09 23:17:31]

srdjan@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2015-11-09 23:17:32]

DBC

https://codereview.chromium.org/1412633007/diff/40001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1412633007/diff/40001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1141: ASSERT(!optimized || Compiler::always_optimize());
Maybe add comment: precompilation can have errors.

[rmacnak, 2015-11-10 02:19:40]

https://codereview.chromium.org/1412633007/diff/40001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1412633007/diff/40001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1141: ASSERT(!optimized || Compiler::always_optimize());
On 2015/11/09 23:17:32, srdjan wrote:
> Maybe add comment: precompilation can have errors.

Added

[siva, 2015-11-12 18:04:11]

lgtm

https://codereview.chromium.org/1412633007/diff/60001/runtime/vm/native_entry.cc
File runtime/vm/native_entry.cc (right):

https://codereview.chromium.org/1412633007/diff/60001/runtime/vm/native_entry...
runtime/vm/native_entry.cc:141: const String& native_name =
String::Handle(func.native_name());
You have the zone so maybe String::Handle(zone, func.native_name)

https://codereview.chromium.org/1412633007/diff/60001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1412633007/diff/60001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:5594: return
reinterpret_cast<RawFunction*>(Array::Cast(obj).At(1));
You can use Function::RawCast(Array::Cast(obj).At(1));

[rmacnak, 2015-11-12 23:51:15]

https://codereview.chromium.org/1412633007/diff/60001/runtime/vm/native_entry.cc
File runtime/vm/native_entry.cc (right):

https://codereview.chromium.org/1412633007/diff/60001/runtime/vm/native_entry...
runtime/vm/native_entry.cc:141: const String& native_name =
String::Handle(func.native_name());
On 2015/11/12 18:04:11, siva wrote:
> You have the zone so maybe String::Handle(zone, func.native_name)

Done.

https://codereview.chromium.org/1412633007/diff/60001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1412633007/diff/60001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:5594: return
reinterpret_cast<RawFunction*>(Array::Cast(obj).At(1));
On 2015/11/12 18:04:11, siva wrote:
> You can use Function::RawCast(Array::Cast(obj).At(1));

RawCast doesn't allow null.

[srdjan, 2015-11-13 00:15:13]

https://codereview.chromium.org/1412633007/diff/60001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1412633007/diff/60001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:5594: return
reinterpret_cast<RawFunction*>(Array::Cast(obj).At(1));
On 2015/11/12 23:51:15, rmacnak wrote:
> On 2015/11/12 18:04:11, siva wrote:
> > You can use Function::RawCast(Array::Cast(obj).At(1));
> 
> RawCast doesn't allow null.

I think reinterpret_cast is quite unsafe. Either have an assert that checks that
At(1) is either function or null, or do something like

Object& res = Object::Handle(Array::Cast(obj).At(1));
return res.IsNull() ? Function::null() : Function::Cast(obj).raw();

[rmacnak, 2015-11-13 01:24:15]

https://codereview.chromium.org/1412633007/diff/60001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1412633007/diff/60001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:5594: return
reinterpret_cast<RawFunction*>(Array::Cast(obj).At(1));
On 2015/11/13 00:15:13, srdjan wrote:
> On 2015/11/12 23:51:15, rmacnak wrote:
> > On 2015/11/12 18:04:11, siva wrote:
> > > You can use Function::RawCast(Array::Cast(obj).At(1));
> > 
> > RawCast doesn't allow null.
> 
> I think reinterpret_cast is quite unsafe. Either have an assert that checks
that
> At(1) is either function or null, or do something like
> 
> Object& res = Object::Handle(Array::Cast(obj).At(1));
> return res.IsNull() ? Function::null() : Function::Cast(obj).raw();

Done.

[rmacnak, 2015-11-13 01:24:47]

Committed patchset #6 (id:100001) manually as
8be0d4aca16feed4edded4d03b95723f7daa879f (presubmit successful).