Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1412633004: Generate license file separately (Closed)

Created:
5 years, 1 month ago by michaelbai
Modified:
5 years, 1 month ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate license file separately So, The license file doesn't need to be generated for each apk. The file could reused by downstream apk. BUG=546219 Committed: https://crrev.com/966adab44ddc72115f4dee2b9e5410f9f55a3919 Cr-Commit-Position: refs/heads/master@{#357185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +18 lines, -0 lines 0 comments Download
M android_webview/apk/system_webview_apk_common.gypi View 2 chunks +3 lines, -21 lines 0 comments Download
M android_webview/apk/system_webview_paks.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
michaelbai
5 years, 1 month ago (2015-10-30 18:37:50 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412633004/1
5 years, 1 month ago (2015-10-30 18:40:37 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-30 19:09:32 UTC) #7
mnaganov (inactive)
LGTM Please be aware that there is a special content provider that extracts the notice ...
5 years, 1 month ago (2015-10-30 19:16:38 UTC) #8
michaelbai
On 2015/10/30 19:16:38, mnaganov wrote: > LGTM > > Please be aware that there is ...
5 years, 1 month ago (2015-10-30 20:25:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412633004/1
5 years, 1 month ago (2015-10-30 20:25:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 20:33:39 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 20:34:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/966adab44ddc72115f4dee2b9e5410f9f55a3919
Cr-Commit-Position: refs/heads/master@{#357185}

Powered by Google App Engine
This is Rietveld 408576698