build/android/devil/constants/exit_codes.py - Issue 1412623009: [Android] Add CLI for flashing devices.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/devil/constants/exit_codes.py

Issue 1412623009: [Android] Add CLI for flashing devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move exit codes Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 #!/bin/sh

2

3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

4 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

5 # found in the LICENSE file.	3 # found in the LICENSE file.

6	4

7 # Version = @@VERSION@@	5 """Common exit codes used by devil."""

8	6

9 /usr/sbin/installer -pkg "$1/@@HOST_PKG@@.pkg" -target /	7 ERROR_EXIT_CODE = 1
	jbudorick 2015/12/01 16:43:26 nit: just ERROR/INFRA/WARNING here. exit_codes.ERR nit: just ERROR/INFRA/WARNING here. exit_codes.ERROR_EXIT_CODE is a bit redundant. rnephew (Reviews Here) 2015/12/01 19:06:11 Done. Show quoted text On 2015/12/01 16:43:26, jbudorick wrote: > nit: just ERROR/INFRA/WARNING here. exit_codes.ERROR_EXIT_CODE is a bit > redundant. Done.
	8 INFRA_EXIT_CODE = 87

	9 WARNING_EXIT_CODE = 88

OLD	NEW