Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2792)

Unified Diff: build/toolchain/mac/BUILD.gn

Issue 1412623007: GN: Factor "stamp" and "copy" details out of toolchains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/gcc_toolchain.gni ('k') | build/toolchain/toolchain.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/mac/BUILD.gn
diff --git a/build/toolchain/mac/BUILD.gn b/build/toolchain/mac/BUILD.gn
index 8d024edb4691b429f6f461a0f8cddfc0b8cfb395..965464ae34e7e885103701f2efacfe1e34aa3b46 100644
--- a/build/toolchain/mac/BUILD.gn
+++ b/build/toolchain/mac/BUILD.gn
@@ -12,6 +12,7 @@ import("//build/config/ios/ios_sdk.gni")
assert(host_os == "mac")
import("//build/toolchain/goma.gni")
+import("//build/toolchain/toolchain.gni")
if (use_goma) {
goma_prefix = "$goma_dir/gomacc "
@@ -205,14 +206,16 @@ template("mac_toolchain") {
]
}
+ # These two are really entirely generic, but have to be repeated in
+ # each toolchain because GN doesn't allow a template to be used here.
+ # See //build/toolchain/toolchain.gni for details.
tool("stamp") {
- command = "touch {{output}}"
- description = "STAMP {{output}}"
+ command = stamp_command
+ description = stamp_description
}
-
tool("copy") {
- command = "ln -f {{source}} {{output}} 2>/dev/null || (rm -rf {{output}} && cp -af {{source}} {{output}})"
- description = "COPY {{source}} {{output}}"
+ command = copy_command
+ description = copy_description
}
toolchain_args() {
« no previous file with comments | « build/toolchain/gcc_toolchain.gni ('k') | build/toolchain/toolchain.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698