Developer Feature: Add Debug Accelerators to Toggle Touchscreen/Touchpad On or Off (CrOS)

ui/base/touch/touch_enabled.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/touch/touch_enabled.h"
+
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "ui/base/touch/touch_device.h"
 #include "ui/base/ui_base_switches.h"
 #include "ui/events/event_switches.h"
 
 namespace ui {
 
+#if defined(OS_CHROMEOS)
+
+namespace {
+
+bool g_touch_events_enabled = true;

[oshima, 2015/10/29 23:38:43]

i'll leave this for owner, but I'd avoid using g_ for non global (this is file
scoped object)

[afakhry, 2015/10/30 05:18:03]

Yes it can be arguable. I meant it's global to this file scope.

[oshima, 2015/10/31 00:27:49]

global and file scoped variable have well defined definition.

g_ is useful to know that it's defined elsewhere and can be accessed by other
files and thread.

anyhow, that's my 2c.

[afakhry, 2015/11/03 18:02:55]

Removed the g_ and moved these two functions to base_event_utils so they can be
used by the touch_factory_x11.

+
+}  // namespace
+
+void SetTouchEventsEnabled(bool enabled) {
+  g_touch_events_enabled = enabled;
+}
+
+#endif  // defined(OS_CHROMEOS)
+
 bool AreTouchEventsEnabled() {
+#if defined(OS_CHROMEOS)
+  return g_touch_events_enabled;
+#else
   const base::CommandLine& command_line =
       *base::CommandLine::ForCurrentProcess();
   const std::string touch_enabled_switch =
       command_line.HasSwitch(switches::kTouchEvents) ?
       command_line.GetSwitchValueASCII(switches::kTouchEvents) :
       switches::kTouchEventsAuto;
 
   if (touch_enabled_switch.empty() ||
       touch_enabled_switch == switches::kTouchEventsEnabled)
     return true;
   if (touch_enabled_switch == switches::kTouchEventsAuto)
     return IsTouchDevicePresent();
   if (touch_enabled_switch != switches::kTouchEventsDisabled)
     LOG(ERROR) << "Invalid --touch-events option: " << touch_enabled_switch;
   return false;
+#endif  // defined(OS_CHROMEOS)
 }
 
 }  // namespace ui