Developer Feature: Add Debug Accelerators to Toggle Touchscreen/Touchpad On or Off (CrOS)

ui/ozone/platform/drm/host/drm_window_host.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/drm/host/drm_window_host.h"
 
 #include "base/bind.h"
+#include "ui/events/base_event_utils.h"
 #include "ui/events/devices/device_data_manager.h"
 #include "ui/events/event.h"
 #include "ui/events/ozone/evdev/event_factory_evdev.h"
 #include "ui/events/ozone/events_ozone.h"
 #include "ui/events/platform/platform_event_source.h"
 #include "ui/gfx/display.h"
 #include "ui/ozone/common/gpu/ozone_gpu_messages.h"
 #include "ui/ozone/platform/drm/host/drm_cursor.h"
 #include "ui/ozone/platform/drm/host/drm_display_host.h"
 #include "ui/ozone/platform/drm/host/drm_display_host_manager.h"
@@ skipping 113 matching lines @@
 bool DrmWindowHost::CanDispatchEvent(const PlatformEvent& ne) {
   DCHECK(ne);
   Event* event = static_cast<Event*>(ne);
 
   // If there is a grab, capture events here.
   gfx::AcceleratedWidget grabber = window_manager_->event_grabber();
   if (grabber != gfx::kNullAcceleratedWidget)
     return grabber == widget_;
 
   if (event->IsTouchEvent()) {
+    if (!ui::AreTouchEventsEnabled())

[spang, 2015/11/03 22:11:45]

If you must do this, this isn't the right place.

Please add something consistent with the touchpad disabling function in
InputController, or have ash handle it by deleting the association via
AssociateTouchscreens().

Then remove the dep on ui/base/touch.

[afakhry, 2015/11/04 02:28:21]

ui/base/touch has been removed from DEPS since it's no longer needed.
I added the call to AreTouchEventsEnabled() here to match what
WindowTreeHostX11::DispatchXI2Event() does by calling
ui::TouchFactory::ShouldProcessXI2Event() which in turn calls
AreTouchEventsEnabled().

I can add a disabling mechanism similar to what the touchpad currently has. For
ozone, the implementation will be similar, but what about
InputDeviceSettingsImplX11? Is there a preferred consistent way of disabling the
touch screen, or should I keep the above mentioned dependency on
ui::TouchFactory::ShouldProcessXI2Event()?

+      return false;
+
     // Dispatch the event if it is from the touchscreen associated with the
     // DrmWindowHost. We cannot check the event's location because if the
     // touchscreen has a bezel, touches in the bezel have a location outside of
     // |bounds_|.
     int64_t display_id =
         DeviceDataManager::GetInstance()->GetTargetDisplayForTouchDevice(
             event->source_device_id());
 
     if (display_id == gfx::Display::kInvalidDisplayID)
       return false;
@@ skipping 52 matching lines @@
   // Update the cursor before the window so that the cursor stays within the
   // window bounds when the window size shrinks.
   cursor_->CommitBoundsChange(widget_, bounds_, GetCursorConfinedBounds());
   sender_->Send(new OzoneGpuMsg_WindowBoundsChanged(widget_, bounds_));
 
   if (overlay_candidates_host_)
     overlay_candidates_host_->ResetCache();
 }
 
 }  // namespace ui