Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1412613006: Add -f as an alias for --force-compile. (Closed)

Created:
5 years, 1 month ago by devoncarew
Modified:
5 years, 1 month ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add -f as an alias for --force-compile. BUG=https://github.com/dart-lang/dev_compiler/issues/372 R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/4a819427dbe9a929d0edebe1ed24ecbc97a3209a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 2 comments Download
M lib/src/options.dart View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
devoncarew
5 years, 1 month ago (2015-10-28 17:21:53 UTC) #2
vsm
lgtm https://codereview.chromium.org/1412613006/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1412613006/diff/1/CHANGELOG.md#newcode4 CHANGELOG.md:4: - added an `--html-report` option to create a ...
5 years, 1 month ago (2015-10-28 17:46:02 UTC) #3
devoncarew
Committed patchset #1 (id:1) manually as 4a819427dbe9a929d0edebe1ed24ecbc97a3209a (presubmit successful).
5 years, 1 month ago (2015-10-28 18:26:32 UTC) #4
devoncarew
5 years, 1 month ago (2015-10-28 18:27:04 UTC) #5
Message was sent while issue was closed.
updated -

https://codereview.chromium.org/1412613006/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/1412613006/diff/1/CHANGELOG.md#newcode4
CHANGELOG.md:4: - added an `--html-report` option to create a file summarizing
compilation issues
On 2015/10/28 17:46:02, vsm wrote:
> nit: line len

:) changed

Powered by Google App Engine
This is Rietveld 408576698