Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1412613005: Move -webkit-filter/background-filter properties into CSSPropertyParser (Closed)

Created:
5 years, 1 month ago by rwlbuis
Modified:
5 years, 1 month ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move -webkit-filter/background-filter properties into CSSPropertyParser Move -webkit-filter/background-filter property handling from LegacyCSSPropertyParser into CSSPropertyParser. This patch also makes consumeAngle handle unitless values (like consumeLength already does). BUG=499780 Committed: https://crrev.com/a672c889ad8c0d6fc379019e57791fe98a7088c5 Cr-Commit-Position: refs/heads/master@{#357303}

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : V3 #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase again #

Patch Set 6 : Ready for review #

Total comments: 13

Patch Set 7 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -205 lines) Patch
M third_party/WebKit/Source/core/css/CSSValueKeywords.in View 1 2 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 5 6 7 chunks +79 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 3 4 5 5 chunks +2 lines, -199 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
rwlbuis
PTAL. this one actually removes a lot of code :)
5 years, 1 month ago (2015-10-30 03:15:53 UTC) #8
Timothy Loh
Patch title/description should probably say that this is the -webkit-filter and background-filter properties, not filter. ...
5 years, 1 month ago (2015-11-02 00:14:07 UTC) #10
rwlbuis
PTAL. https://codereview.chromium.org/1412613005/diff/100001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1412613005/diff/100001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode1425 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1425: static PassRefPtrWillBeRawPtr<CSSFunctionValue> parseBuiltinFilterArguments(CSSParserTokenRange& range, const CSSParserContext& context) On ...
5 years, 1 month ago (2015-11-02 02:07:51 UTC) #12
Timothy Loh
lgtm https://codereview.chromium.org/1412613005/diff/100001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1412613005/diff/100001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode1476 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1476: String url = consumeUrl(range); On 2015/11/02 02:07:50, rwlbuis ...
5 years, 1 month ago (2015-11-02 02:17:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412613005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412613005/120001
5 years, 1 month ago (2015-11-02 02:39:06 UTC) #16
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 1 month ago (2015-11-02 04:05:06 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 04:05:59 UTC) #18
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/a672c889ad8c0d6fc379019e57791fe98a7088c5
Cr-Commit-Position: refs/heads/master@{#357303}

Powered by Google App Engine
This is Rietveld 408576698