gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc - Issue 1412613004: Set attachment for bound framebuffer in FramebufferTextureLayer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

Issue 1412613004: Set attachment for bound framebuffer in FramebufferTextureLayer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix WebGLTextureAttachment::attach Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

index 95ada5dcf5c665ec2daed54a962eddd1008b6391..36b099ba487a45ad63c8a1398308f6a259783013 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

@@ -143,6 +143,19 @@ void GLES2DecoderTestBase::SpecializedSetup<cmds::FramebufferTexture2D, 0>(

};

template <>

+void GLES2DecoderTestBase::SpecializedSetup<cmds::FramebufferTextureLayer, 0>(

+ bool valid) {

+ DoBindFramebuffer(GL_FRAMEBUFFER, client_framebuffer_id_,

+ kServiceFramebufferId);

+ if (valid) {

+ EXPECT_CALL(*gl_, GetError())

+ .WillOnce(Return(GL_NO_ERROR))

+ .RetiresOnSaturation();

+ }

+};

+template <>

void GLES2DecoderTestBase::SpecializedSetup<

cmds::GetBufferParameteri64v, 0>(bool /* valid */) {

DoBindBuffer(GL_ARRAY_BUFFER, client_buffer_id_, kServiceBufferId);