third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h - Issue 1412613004: Set attachment for bound framebuffer in FramebufferTextureLayer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 1412613004: Set attachment for bound framebuffer in FramebufferTextureLayer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more validations and fix gpu_unittests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc ('k') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

index a2427378b835f194a7d1c854d409b3e9a90cce19..1b28417249d28efa0349c5f1425ea2de7e461ae1 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

@@ -32,8 +32,9 @@ public:

void getBufferSubData(GLenum target, long long offset, DOMArrayBuffer* returnedData);

/* Framebuffer objects */

+ bool validateTextureLayer(const char*, GLenum target, GLint layer);

void blitFramebuffer(GLint, GLint, GLint, GLint, GLint, GLint, GLint, GLint, GLbitfield, GLenum);

- void framebufferTextureLayer(GLenum, GLenum, const WebGLTexture*, GLint, GLint);

+ void framebufferTextureLayer(ScriptState*, GLenum, GLenum, WebGLTexture*, GLint, GLint);

ScriptValue getInternalformatParameter(ScriptState*, GLenum, GLenum, GLenum);

void invalidateFramebuffer(GLenum, Vector<GLenum>&);

void invalidateSubFramebuffer(GLenum, Vector<GLenum>&, GLint, GLint, GLsizei, GLsizei);

@@ -235,6 +236,7 @@ protected:

PersistentWillBeMember<WebGLTransformFeedback> m_transformFeedbackBinding;

GLint m_max3DTextureSize;

GLint m_max3DTextureLevel;

+ GLint m_maxArrayTextureLayers;

std::set<GLenum> m_supportedInternalFormatsStorage;