Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1412573012: Option support for `enableGenericMethods`. (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Option support for `enableGenericMethods`. * Adds `enableGenericMethods` language configuration support to `.analysis_options`: analyzer: language: enableGenericMethods: true (with validation). * Fixes `AnalysisOptionsImpl` to properly set (and copy) enableGenericMethods settings. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/53d791d626848024a58e19568cc98ae6c46955ba

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 3 chunks +14 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 1 month ago (2015-11-06 06:49:55 UTC) #2
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-06 15:51:44 UTC) #3
pquitslund
5 years, 1 month ago (2015-11-06 18:31:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
53d791d626848024a58e19568cc98ae6c46955ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698