Run Mojo apptests step on Windows main and cq bots.

Run Mojo apptests step on Windows main and cq bots.

Add mojo_apptests step to 'Win8 Aura' buildbot config for these bots:
  http://build.chromium.org/p/chromium.win/builders/Win8%20Aura
  http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng

The step has run on FYI for months, with no flakes for 1 week:
  http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Windows
(recent changes addressed blocking flakiness: http://crbug.com/517661)

BUG=478244, 517661
TEST=New step passes on intended bots.
R=dpranke@chromium.org
TBR=phajdan.jr@chromium.org

Committed: https://crrev.com/3e18cf082b743ba0209a38509f2b62f0c9b76638
Cr-Commit-Position: refs/heads/master@{#357425}

[msw, 2015-10-29 21:28:21]

Hey Dirk, please take a look; thanks!

https://codereview.chromium.org/1412563007/diff/1/testing/buildbot/chromium.w...
File testing/buildbot/chromium.win.json (right):

https://codereview.chromium.org/1412563007/diff/1/testing/buildbot/chromium.w...
testing/buildbot/chromium.win.json:704: "Win x64 GN": {
This bot (and the win_chromium_gn_x64_rel using this config) also builds GN
non-component, and *could* run the apptests step, but it doesn't seem to run any
tests at all for now, so I've left it alone, sgty?

https://codereview.chromium.org/1412563007/diff/1/testing/buildbot/chromium.w...
testing/buildbot/chromium.win.json:1475: "Win8 Aura": {
Is 'Win8 Aura' and 'win8_chromium_ng' the right bots to target?
(want to ensure they're not slated for imminent removal, etc.)

[Dirk Pranke, 2015-10-29 21:33:41]

lgtm

https://codereview.chromium.org/1412563007/diff/1/testing/buildbot/chromium.w...
File testing/buildbot/chromium.win.json (right):

https://codereview.chromium.org/1412563007/diff/1/testing/buildbot/chromium.w...
testing/buildbot/chromium.win.json:704: "Win x64 GN": {
On 2015/10/29 21:28:20, msw wrote:
> This bot (and the win_chromium_gn_x64_rel using this config) also builds GN
> non-component, and *could* run the apptests step, but it doesn't seem to run
any
> tests at all for now, so I've left it alone, sgty?

Sure, that's fine.

https://codereview.chromium.org/1412563007/diff/1/testing/buildbot/chromium.w...
testing/buildbot/chromium.win.json:1475: "Win8 Aura": {
On 2015/10/29 21:28:20, msw wrote:
> Is 'Win8 Aura' and 'win8_chromium_ng' the right bots to target?
> (want to ensure they're not slated for imminent removal, etc.)

Yes, this is the right bot to change.

[msw, 2015-10-29 21:41:52]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2015-10-29 21:42:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412563007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412563007/1

[msw, 2015-10-29 22:29:11]

The CQ bit was unchecked by msw@chromium.org

[msw, 2015-10-29 22:30:17]

Cancelled cq; looks like the win8_chromium_ng failure is real:
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...
Running
['E:\\b\\build\\slave\\win_gn\\build\\src\\mojo\\tools\\apptest_runner.py',
'E:\\b\\build\\slave\\win_gn\\build\\src\\out\\Release', '--verbose',
'--write-full-results-to',
'c:\\users\\chrome~1\\appdata\\local\\temp\\tmp5h8ckz']
Traceback (most recent call last):
  File "E:\b\build\slave\win_gn\build\src\testing\scripts\mojo_apptests.py",
line 45, in <module>
    sys.exit(common.run_script(sys.argv[1:], funcs))
  File "E:\b\build\slave\win_gn\build\src\testing\scripts\common.py", line 59,
in run_script
    return args.func(args)
  File "E:\b\build\slave\win_gn\build\src\testing\scripts\mojo_apptests.py",
line 20, in main_run
    '--write-full-results-to', tempfile_path])
  File "E:\b\build\slave\win_gn\build\src\testing\scripts\common.py", line 64,
in run_command
    rc = subprocess.call(argv, env=env)
  File "E:\b\depot_tools\python276_bin\lib\subprocess.py", line 522, in call
    return Popen(*popenargs, **kwargs).wait()
  File "E:\b\depot_tools\python276_bin\lib\subprocess.py", line 709, in __init__
    errread, errwrite)
  File "E:\b\depot_tools\python276_bin\lib\subprocess.py", line 957, in
_execute_child
    startupinfo)
WindowsError: [Error 193] %1 is not a valid Win32 application

[msw, 2015-10-30 21:59:56]

On 2015/10/29 22:30:17, msw wrote:
> Cancelled cq; looks like the win8_chromium_ng failure is real:
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...
> Running
> ['E:\\b\\build\\slave\\win_gn\\build\\src\\mojo\\tools\\apptest_runner.py',
> 'E:\\b\\build\\slave\\win_gn\\build\\src\\out\\Release', '--verbose',
> '--write-full-results-to',
> 'c:\\users\\chrome~1\\appdata\\local\\temp\\tmp5h8ckz']
> Traceback (most recent call last):
>   File "E:\b\build\slave\win_gn\build\src\testing\scripts\mojo_apptests.py",
> line 45, in <module>
>     sys.exit(common.run_script(sys.argv[1:], funcs))
>   File "E:\b\build\slave\win_gn\build\src\testing\scripts\common.py", line 59,
> in run_script
>     return args.func(args)
>   File "E:\b\build\slave\win_gn\build\src\testing\scripts\mojo_apptests.py",
> line 20, in main_run
>     '--write-full-results-to', tempfile_path])
>   File "E:\b\build\slave\win_gn\build\src\testing\scripts\common.py", line 64,
> in run_command
>     rc = subprocess.call(argv, env=env)
>   File "E:\b\depot_tools\python276_bin\lib\subprocess.py", line 522, in call
>     return Popen(*popenargs, **kwargs).wait()
>   File "E:\b\depot_tools\python276_bin\lib\subprocess.py", line 709, in
__init__
>     errread, errwrite)
>   File "E:\b\depot_tools\python276_bin\lib\subprocess.py", line 957, in
> _execute_child
>     startupinfo)
> WindowsError: [Error 193] %1 is not a valid Win32 application

Weirdly, the cq retry failed with clear error:
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...
Running
['E:\\b\\build\\slave\\win_gn\\build\\src\\mojo\\tools\\apptest_runner.py',
'E:\\b\\build\\slave\\win_gn\\build\\src\\out\\Release', '--verbose',
'--write-full-results-to',
'c:\\users\\chrome~2\\appdata\\local\\temp\\tmpx2rbd2']

@@@STEP_CURSOR mojo_apptests (with patch)@@@

@@@STEP_LOG_LINE@json.output (invalid)@null@@@

@@@STEP_LOG_END@json.output (invalid)@@@

@@@STEP_FAILURE@@@

@@@STEP_CURSOR mojo_apptests (with patch)@@@

[msw, 2015-10-30 22:20:33]

Added sys.executable to the mojo_apptests.py commandline, as you suggested,
Dirk; trying again now.

[msw, 2015-10-30 22:20:42]

The CQ bit was checked by msw@chromium.org

[msw, 2015-10-30 22:20:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1412563007/#ps20001
(title: "Use sys.executable in mojo_apptests.py commandline.")

[commit-bot: I haz the power, 2015-10-30 22:21:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412563007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412563007/20001

[commit-bot: I haz the power, 2015-10-30 22:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 22:37:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[msw, 2015-10-30 22:40:22]

Description was changed from

==========
Run Mojo apptests step on Windows main and cq bots.

Add mojo_apptests step to 'Win8 Aura' buildbot config for these bots:
  http://build.chromium.org/p/chromium.win/builders/Win8%20Aura
  http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng

The step has run on FYI for months, with no flakes for 1 week:
  http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Windows
(recent changes addressed blocking flakiness: http://crbug.com/517661)

BUG=478244,517661
TEST=New step passes on intended bots.
R=dpranke@chromium.org
==========

to

==========
Run Mojo apptests step on Windows main and cq bots.

Add mojo_apptests step to 'Win8 Aura' buildbot config for these bots:
  http://build.chromium.org/p/chromium.win/builders/Win8%20Aura
  http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng

The step has run on FYI for months, with no flakes for 1 week:
  http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Windows
(recent changes addressed blocking flakiness: http://crbug.com/517661)

BUG=478244,517661
TEST=New step passes on intended bots.
R=dpranke@chromium.org
TBR=phajdan.jr@chromium.org
==========

[msw, 2015-10-30 22:40:22]

msw@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[msw, 2015-10-30 22:41:05]

TBR'ing Paweł for testing/scripts/OWNERS

[Paweł Hajdan Jr., 2015-11-02 11:27:17]

LGTM

[msw, 2015-11-02 19:24:46]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2015-11-02 19:26:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412563007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412563007/20001

[commit-bot: I haz the power, 2015-11-02 20:51:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-02 20:52:47]

Patchset 2 (id:??) landed as
https://crrev.com/3e18cf082b743ba0209a38509f2b62f0c9b76638
Cr-Commit-Position: refs/heads/master@{#357425}

[msw, 2015-11-05 19:20:15]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1413773009/ by msw@chromium.org.

The reason for reverting is: The mojo_apptests step is failing flakily due to a
high incidence rate of http://crbug.com/551083 (Flaky mojo BaseThreadInitThunk /
RtlInitializeExceptionChain crashes on Windows).