chrome/common/extensions/docs/server2/cron_servlet.py - Issue 14125010: Docserver: Add support for viewing docs with a codereview patch applied

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/cron_servlet.py

Issue 14125010: Docserver: Add support for viewing docs with a codereview patch applied (Closed) Base URL: https://src.chromium.org/svn/trunk/src/

Patch Set: everything but patch_servlet Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/server2/chained_compiled_file_system.py ('K') | « chrome/common/extensions/docs/server2/cron.yaml ('k') | chrome/common/extensions/docs/server2/fake_fetchers.py » ('j') | chrome/common/extensions/docs/server2/patch_servlet.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/cron_servlet.py

===================================================================

--- chrome/common/extensions/docs/server2/cron_servlet.py (revision 199575)

+++ chrome/common/extensions/docs/server2/cron_servlet.py (working copy)

@@ -11,6 +11,7 @@

GetAppVersion, DeadlineExceededError, IsDevServer, logservice)

from branch_utility import BranchUtility

from caching_file_system import CachingFileSystem

+from compiled_file_system import CompiledFileSystem

from empty_dir_file_system import EmptyDirFileSystem

from github_file_system import GithubFileSystem

from object_store_creator import ObjectStoreCreator

@@ -227,7 +228,13 @@

object_store_creator)

app_samples_file_system = self._delegate.CreateAppSamplesFileSystem(

object_store_creator)

+ compiled_host_fs_factory = CompiledFileSystem.Factory(

+ host_file_system,

+ object_store_creator)

return ServerInstance(channel,

object_store_creator,

host_file_system,

- app_samples_file_system)

+ app_samples_file_system,

+ '/static' if channel == 'stable' else

+ '/%s/static' % channel,

+ compiled_host_fs_factory)