chrome/common/extensions/docs/server2/patcher.py - Issue 14125010: Docserver: Add support for viewing docs with a codereview patch applied

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/server2/patcher.py

Issue 14125010: Docserver: Add support for viewing docs with a codereview patch applied (Closed) Base URL: https://src.chromium.org/svn/trunk/src/

Patch Set: rebase Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/server2/patched_file_system.py ('K') | « chrome/common/extensions/docs/server2/patched_file_system_test.py ('k') | chrome/common/extensions/docs/server2/rietveld_patcher.py » ('j') | chrome/common/extensions/docs/server2/server_instance.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Property Changes:

Added: svn:eol-style
+ LF

OLD	NEW
(Empty)
	1 # Copyright 2013 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 class Patcher(object):

	6 def GetPatchedFiles(self, version=None):

	7 ''' Returns (added_files, deleted_files, modified_files).
	not at google - send to devlin 2013/05/11 20:39:53 Comment what version= means. Comment what version= means. 方觉(Fang Jue) 2013/05/12 03:01:47 Done. Show quoted text On 2013/05/11 20:39:53, kalman wrote: > Comment what version= means. Done.
	8 '''

	9 raise NotImplementedError()

	10

	11 def GetVersion(self):

	12 ''' Returns patch version. Returns None when nothing is patched by the

	13 patcher.

	14 '''

	15 raise NotImplementedError()

	16

	17 def Apply(self, paths, file_system, binary, version=None):
	not at google - send to devlin 2013/05/11 20:39:53 I can't see file_system being used anywhere I can't see file_system being used anywhere 方觉(Fang Jue) 2013/05/12 03:01:47 No. It's not actually used because RietveldPatcher Show quoted text On 2013/05/11 20:39:53, kalman wrote: > I can't see file_system being used anywhere No. It's not actually used because RietveldPatcher doesn't really do patching against existing files. It just returns patched files' data. However, other kind of patchers do need this.
	18 ''' Apply the patch to added/modified files. Returns Future with patched

	19 data. Throws FileNotFoundError if \|paths\| contains deleted files.
	not at google - send to devlin 2013/05/11 20:39:53 comment what version= means. P.S. I was under the comment what version= means. P.S. I was under the impression that codereview has issues with binary files? Nevermind. 方觉(Fang Jue) 2013/05/12 03:01:47 Yes. And trying to fetch tarball for an issue with Show quoted text On 2013/05/11 20:39:53, kalman wrote: > comment what version= means. > > P.S. I was under the impression that codereview has issues with binary files? > Nevermind. Yes. And trying to fetch tarball for an issue with binary files results in a 500. But anyway, if it is fixed in the future, it should work with binary files too.
	20 '''

	21 raise NotImplementedError()

OLD	NEW