Move global code for builtins into setup functions.

Move global code for builtins into setup functions.

R=rossberg@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=14228

[Michael Starzinger, 2013-04-11 11:17:56]

This is a cleanup to prevent us from searching for
"$Object.constructor.prototype" assignments in global code for half a day again.
:)

[rossberg, 2013-04-11 12:00:18]

https://codereview.chromium.org/14125004/diff/1013/src/proxy.js
File src/proxy.js (right):

https://codereview.chromium.org/14125004/diff/1013/src/proxy.js#newcode198
src/proxy.js:198: function SetUpProxy() {
I don't like separating this from the method definitions, I think it should go
before the built-ins.

https://codereview.chromium.org/14125004/diff/1013/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/14125004/diff/1013/src/v8natives.js#newcode226
src/v8natives.js:226: function BooleanConstructor(x) {
Move this to the rest of the Boolean stuff.

https://codereview.chromium.org/14125004/diff/1013/src/v8natives.js#newcode1610
src/v8natives.js:1610: // Set the Number function and constructor.
Nit: remove this comment

[rossberg, 2013-04-11 12:02:29]

https://codereview.chromium.org/14125004/diff/1013/src/collection.js
File src/collection.js (right):

https://codereview.chromium.org/14125004/diff/1013/src/collection.js#newcode249
src/collection.js:249: function SetUpCollections() {
Actually, I think this should be split up into SetUpSet, SetUpMap, and
SetUpWeakMap, and moved closer to the respective methods, with separators like
in v8natives.

[Michael Starzinger, 2013-04-11 12:08:44]

Comments addressed.

https://codereview.chromium.org/14125004/diff/1013/src/collection.js
File src/collection.js (right):

https://codereview.chromium.org/14125004/diff/1013/src/collection.js#newcode249
src/collection.js:249: function SetUpCollections() {
On 2013/04/11 12:02:29, rossberg wrote:
> Actually, I think this should be split up into SetUpSet, SetUpMap, and
> SetUpWeakMap, and moved closer to the respective methods, with separators like
> in v8natives.

Done.

https://codereview.chromium.org/14125004/diff/1013/src/proxy.js
File src/proxy.js (right):

https://codereview.chromium.org/14125004/diff/1013/src/proxy.js#newcode198
src/proxy.js:198: function SetUpProxy() {
On 2013/04/11 12:00:18, rossberg wrote:
> I don't like separating this from the method definitions, I think it should go
> before the built-ins.

Done (likewise for JSON).

https://codereview.chromium.org/14125004/diff/1013/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/14125004/diff/1013/src/v8natives.js#newcode226
src/v8natives.js:226: function BooleanConstructor(x) {
On 2013/04/11 12:00:18, rossberg wrote:
> Move this to the rest of the Boolean stuff.

Done.

https://codereview.chromium.org/14125004/diff/1013/src/v8natives.js#newcode1610
src/v8natives.js:1610: // Set the Number function and constructor.
On 2013/04/11 12:00:18, rossberg wrote:
> Nit: remove this comment

Done.

[rossberg, 2013-04-11 12:12:40]

lgtm

[Michael Starzinger, 2013-04-11 12:15:58]

Committed patchset #4 manually as r14228 (presubmit successful).