Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: net/ssl/ssl_config_service_unittest.cc

Issue 14125003: Do not roll back to SSL 3.0 for Google properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a bug that prevents TLS 1.1 -> TLS 1.0 fallback. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/ssl/ssl_config_service.cc ('K') | « net/ssl/ssl_config_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/ssl_config_service_unittest.cc
diff --git a/net/ssl/ssl_config_service_unittest.cc b/net/ssl/ssl_config_service_unittest.cc
index e8a4c33394a0b18325fb3904e4a8cf63be6c840d..c76b2946a2d1528c008b6a8735a3e0175b71c9df 100644
--- a/net/ssl/ssl_config_service_unittest.cc
+++ b/net/ssl/ssl_config_service_unittest.cc
@@ -71,6 +71,7 @@ TEST(SSLConfigServiceTest, ConfigUpdatesNotifyObservers) {
initial_config.false_start_enabled = false;
initial_config.version_min = SSL_PROTOCOL_VERSION_SSL3;
initial_config.version_max = SSL_PROTOCOL_VERSION_TLS1_1;
+ initial_config.ssl3_fallback_enabled = false;
wtc 2013/04/18 18:15:34 Set this after line 71 (initial_config.false_start
scoped_refptr<MockSSLConfigService> mock_service(
new MockSSLConfigService(initial_config));
@@ -95,6 +96,10 @@ TEST(SSLConfigServiceTest, ConfigUpdatesNotifyObservers) {
EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
mock_service->SetSSLConfig(initial_config);
+ initial_config.ssl3_fallback_enabled = true;
+ EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
+ mock_service->SetSSLConfig(initial_config);
wtc 2013/04/18 18:15:34 Do this after lines 86-88 (which deals with false_
+
// Test that disabling certain cipher suites triggers an update.
std::vector<uint16> disabled_ciphers;
disabled_ciphers.push_back(0x0004u);
« net/ssl/ssl_config_service.cc ('K') | « net/ssl/ssl_config_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698