Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: net/ssl/ssl_config_service.cc

Issue 14125003: Do not roll back to SSL 3.0 for Google properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a bug that prevents TLS 1.1 -> TLS 1.0 fallback. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/ssl/ssl_config_service.cc
diff --git a/net/ssl/ssl_config_service.cc b/net/ssl/ssl_config_service.cc
index f46dd7b7dc72450d91be28d10b4a9c3135837fac..b1a734995ecf2d8a3594a730de3951c2cc470659 100644
--- a/net/ssl/ssl_config_service.cc
+++ b/net/ssl/ssl_config_service.cc
@@ -40,6 +40,7 @@ SSLConfig::SSLConfig()
cached_info_enabled(false),
channel_id_enabled(true),
false_start_enabled(true),
+ ssl3_fallback_enabled(false),
send_client_cert(false),
verify_ev_cert(false),
version_fallback(false),
@@ -154,8 +155,10 @@ void SSLConfigService::ProcessConfigUpdate(const SSLConfig& orig_config,
(orig_config.version_min != new_config.version_min) ||
(orig_config.version_max != new_config.version_max) ||
(orig_config.disabled_cipher_suites !=
- new_config.disabled_cipher_suites) ||
+ new_config.disabled_cipher_suites) ||
(orig_config.channel_id_enabled != new_config.channel_id_enabled) ||
+ (orig_config.ssl3_fallback_enabled !=
+ new_config.ssl3_fallback_enabled) ||
wtc 2013/04/18 18:15:34 Please add this test after the false_start_enabled
(orig_config.false_start_enabled != new_config.false_start_enabled);
if (config_changed)

Powered by Google App Engine
This is Rietveld 408576698