Do not roll back to SSL 3.0 for Google properties.

net/http/http_network_transaction.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_NETWORK_TRANSACTION_H_
 #define NET_HTTP_HTTP_NETWORK_TRANSACTION_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 67 matching lines @@
       const HttpResponseInfo& response_info,
       const SSLConfig& used_ssl_config,
       const ProxyInfo& used_proxy_info,
       HttpAuthController* auth_controller) OVERRIDE;
   virtual void OnNeedsClientAuth(const SSLConfig& used_ssl_config,
                                  SSLCertRequestInfo* cert_info) OVERRIDE;
   virtual void OnHttpsProxyTunnelResponse(const HttpResponseInfo& response_info,
                                           const SSLConfig& used_ssl_config,
                                           const ProxyInfo& used_proxy_info,
                                           HttpStreamBase* stream) OVERRIDE;
+  // For testing.
+  SSLConfig& server_ssl_config() { return server_ssl_config_; }

[agl, 2013/04/15 15:23:51]

server_ssl_config_for_testing()

(If it's a testing function then let's make it really clear.)

Alternatively, it looks like the style here is to use FRIEND_TEST_ALL_PREFIXES
for the tests.

[Ryan Sleevi, 2013/04/15 18:03:28]

+1 to either FRIEND_TEST_ALL_PREFIXES or friending the test fixture and adding a
protected getter to the test fixture for the individual tests.

[thaidn_google, 2013/04/16 00:38:16]

Done.

 
  private:
   FRIEND_TEST_ALL_PREFIXES(HttpNetworkTransactionSpdy2Test,
                            ResetStateForRestart);
   FRIEND_TEST_ALL_PREFIXES(HttpNetworkTransactionSpdy3Test,
                            ResetStateForRestart);
   FRIEND_TEST_ALL_PREFIXES(SpdyNetworkTransactionSpdy2Test,
                            WindowUpdateReceived);
   FRIEND_TEST_ALL_PREFIXES(SpdyNetworkTransactionSpdy2Test,
                            WindowUpdateSent);
@@ skipping 210 matching lines @@
   // True when the tunnel is in the process of being established - we can't
   // read from the socket until the tunnel is done.
   bool establishing_tunnel_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpNetworkTransaction);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_NETWORK_TRANSACTION_H_