Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412463006: [DevTools] Use ListWidget to render DevicesSettingsTab. (Closed)

Created:
5 years, 1 month ago by dgozman
Modified:
5 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Use ListWidget to render DevicesSettingsTab. BUG=none Committed: https://crrev.com/aaad278dc8dbbcb44b5fdf6045c5d919d1e6d342 Cr-Commit-Position: refs/heads/master@{#356987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -287 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js View 6 chunks +132 lines, -198 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/devicesSettingsTab.css View 3 chunks +19 lines, -88 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dgozman
Take a look please.
5 years, 1 month ago (2015-10-29 21:59:23 UTC) #2
pfeldman
lgtm
5 years, 1 month ago (2015-10-29 22:29:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412463006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412463006/1
5 years, 1 month ago (2015-10-29 22:37:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 23:47:27 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 23:48:13 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aaad278dc8dbbcb44b5fdf6045c5d919d1e6d342
Cr-Commit-Position: refs/heads/master@{#356987}

Powered by Google App Engine
This is Rietveld 408576698