Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1412453004: Add some community and testing info to README.md. (Closed)

Created:
5 years, 2 months ago by dsinclair
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add some community and testing info to README.md. This CL adds some more context to the README on the various test suites and community mailing lists which are available. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/51cf5bc00dfa3033523355e3e74f3a47f7e46682

Patch Set 1 #

Total comments: 13

Patch Set 2 : #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -24 lines) Patch
M README.md View 1 4 chunks +40 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
dsinclair
PTAL. Wanted to write down some of the things I've found out. https://codereview.chromium.org/1412453004/diff/1/README.md File README.md ...
5 years, 2 months ago (2015-10-15 23:53:58 UTC) #2
Tom Sepez
very nice. https://codereview.chromium.org/1412453004/diff/1/README.md File README.md (left): https://codereview.chromium.org/1412453004/diff/1/README.md#oldcode12 README.md:12: build system (recommended) rather than using your ...
5 years, 2 months ago (2015-10-16 00:09:55 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/1412453004/diff/1/README.md File README.md (left): https://codereview.chromium.org/1412453004/diff/1/README.md#oldcode12 README.md:12: build system (recommended) rather than using your platform-specific ...
5 years, 2 months ago (2015-10-16 00:14:12 UTC) #4
dsinclair
https://codereview.chromium.org/1412453004/diff/1/README.md File README.md (right): https://codereview.chromium.org/1412453004/diff/1/README.md#newcode47 README.md:47: * On Linux: `make pdfium\_test` On 2015/10/16 00:14:12, Lei ...
5 years, 2 months ago (2015-10-16 00:41:26 UTC) #5
dsinclair
Committed patchset #3 (id:40001) manually as 51cf5bc00dfa3033523355e3e74f3a47f7e46682 (presubmit successful).
5 years, 2 months ago (2015-10-16 00:42:48 UTC) #6
Tom Sepez
5 years, 2 months ago (2015-10-16 18:18:07 UTC) #7
Message was sent while issue was closed.
On 2015/10/16 00:42:48, dsinclair wrote:
> Committed patchset #3 (id:40001) manually as
> 51cf5bc00dfa3033523355e3e74f3a47f7e46682 (presubmit successful).

Ooops, I'm seeing unexpected backslashes when viewing
https://pdfium.googlesource.com/pdfium/.  I guess these aren't needed in code
blocks?

Powered by Google App Engine
This is Rietveld 408576698