Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2212)

Unified Diff: chrome/browser/profiles/host_zoom_map_browsertest.cc

Issue 1412453002: Remove enable-iframe-based-signin flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/host_zoom_map_browsertest.cc
diff --git a/chrome/browser/profiles/host_zoom_map_browsertest.cc b/chrome/browser/profiles/host_zoom_map_browsertest.cc
index 2fdf7811d7ce604115f39d52a1d5db0cfa9ac25b..7cf2ed71108cc78d7c7e74c87af8a84fb960d127 100644
--- a/chrome/browser/profiles/host_zoom_map_browsertest.cc
+++ b/chrome/browser/profiles/host_zoom_map_browsertest.cc
@@ -257,19 +257,10 @@ IN_PROC_BROWSER_TEST_F(
// zoom map.
HostZoomMap* default_profile_host_zoom_map =
HostZoomMap::GetDefaultForBrowserContext(browser()->profile());
- // Since ChromeOS still uses IFrame-based signin, we should expect the
- // storage partition to be different if Webview signin is not enabled.
- if (switches::IsEnableWebviewBasedSignin())
- EXPECT_EQ(host_zoom_map, default_profile_host_zoom_map);
- else
- EXPECT_NE(host_zoom_map, default_profile_host_zoom_map);
+ EXPECT_EQ(host_zoom_map, default_profile_host_zoom_map);
}
class HostZoomMapIframeSigninBrowserTest : public HostZoomMapBrowserTest {
- public:
- void SetUpCommandLine(base::CommandLine* command_line) override {
- command_line->AppendSwitch(switches::kEnableIframeBasedSignin);
- }
};
// Regression test for crbug.com/435017.
@@ -293,10 +284,9 @@ IN_PROC_BROWSER_TEST_F(HostZoomMapIframeSigninBrowserTest,
// be in a different storage partition, and hence a different HostZoomMap.
HostZoomMap* host_zoom_map = HostZoomMap::GetForWebContents(web_contents);
- EXPECT_FALSE(switches::IsEnableWebviewBasedSignin());
HostZoomMap* default_profile_host_zoom_map =
HostZoomMap::GetDefaultForBrowserContext(browser()->profile());
- EXPECT_NE(host_zoom_map, default_profile_host_zoom_map);
+ EXPECT_EQ(host_zoom_map, default_profile_host_zoom_map);
double new_zoom_level =
host_zoom_map->GetZoomLevelForHostAndScheme(test_scheme, test_host) + 0.5;

Powered by Google App Engine
This is Rietveld 408576698