Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1412443010: [turbofan] Switch message object manipulation to JSOperator. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Switch message object manipulation to JSOperator. This switches loading and storing of the message object within the Isolate to use JavaScript operators built by the JSOperatorBuilder instead of machine operators. This is a preparation for a stricter representation selection for loads and stores. R=jarin@chromium.org Committed: https://crrev.com/270be9351cd4e137d6a2a7311e7efc7a891daee6 Cr-Commit-Position: refs/heads/master@{#31879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -51 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 6 chunks +4 lines, -25 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +24 lines, -22 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-09 12:11:22 UTC) #1
Jarin
lgtm. Thanks!
5 years, 1 month ago (2015-11-09 12:42:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412443010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412443010/1
5 years, 1 month ago (2015-11-09 12:42:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 12:44:25 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 12:44:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/270be9351cd4e137d6a2a7311e7efc7a891daee6
Cr-Commit-Position: refs/heads/master@{#31879}

Powered by Google App Engine
This is Rietveld 408576698