Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1412433003: Revert of Android: Trust large random numbers for temp files (Closed)

Created:
5 years, 2 months ago by Mark P
Modified:
5 years, 2 months ago
Reviewers:
jbudorick, agrieve
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android: Trust large random numbers for temp files (patchset #1 id:1 of https://codereview.chromium.org/1402353002/ ) Reason for revert: Likely cause of Android GN breakage in stack_tool_for_tombstones: https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/31358 Traceback (most recent call last): File "/b/build/slave/Android_GN/build/src/build/android/tombstones.py", line 257, in <module> sys.exit(main()) File "/b/build/slave/Android_GN/build/src/build/android/tombstones.py", line 251, in main tombstones += _GetTombstonesForDevice(device, options) File "/b/build/slave/Android_GN/build/src/build/android/tombstones.py", line 197, in _GetTombstonesForDevice 'data': _GetTombstoneData(device, tombstone_file)}] File "/b/build/slave/Android_GN/build/src/build/android/tombstones.py", line 79, in _GetTombstoneData '/data/tombstones/' + tombstone_file, as_root=True).splitlines() File "/b/build/slave/Android_GN/build/src/build/android/devil/android/decorators.py", line 53, in timeout_retry_wrapper return timeout_retry.Run(impl, timeout, retries, desc=desc) File "/b/build/slave/Android_GN/build/src/build/android/devil/utils/timeout_retry.py", line 161, in Run error_log_func=error_log_func) File "/b/build/slave/Android_GN/build/src/build/android/devil/utils/reraiser_thread.py", line 186, in JoinAll self._JoinAll(watcher, timeout) File "/b/build/slave/Android_GN/build/src/build/android/devil/utils/reraiser_thread.py", line 158, in _JoinAll thread.ReraiseIfException() File "/b/build/slave/Android_GN/build/src/build/android/devil/utils/reraiser_thread.py", line 81, in run self._ret = self._func(*self._args, **self._kwargs) File "/b/build/slave/Android_GN/build/src/build/android/devil/utils/timeout_retry.py", line 154, in <lambda> child_thread = reraiser_thread.ReraiserThread(lambda: func(*args, **kwargs), File "/b/build/slave/Android_GN/build/src/build/android/devil/android/decorators.py", line 44, in impl return f(*args, **kwargs) File "/b/build/slave/Android_GN/build/src/build/android/devil/android/device_utils.py", line 1441, in ReadFile return self._ReadFileWithPull(device_temp.name) File "/b/build/slave/Android_GN/build/src/build/android/devil/android/device_utils.py", line 1384, in _ReadFileWithPull self.adb.Pull(device_path, host_temp_path) File "/b/build/slave/Android_GN/build/src/build/android/devil/android/sdk/adb_wrapper.py", line 247, in Pull cmd, 'File not found on host: %s' % local, device_serial=str(self)) devil.android.device_errors.AdbCommandFailedError: (device: 0528be3e0a286d60) adb pull /data/local/tmp/temp_file-ff7f09e4cdfa0 /tmp/tmpYJtAXL/tmp_ReadFileWithPull: failed and output: - File not found on host: /tmp/tmpYJtAXL/tmp_ReadFileWithPull Original issue's description: > Android: Trust large random numbers for temp files > > Saves a good amount of time (150ms per) and log pollution to not execute an adb > command for each temp file. > > BUG=540857 > > Committed: https://crrev.com/a5a882f8e9325c782db666c27831cc82f119ced7 > Cr-Commit-Position: refs/heads/master@{#354332} TBR=jbudorick@chromium.org,agrieve@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=540857 Committed: https://crrev.com/011b0059489c76c8ef45456ef8131217398c4fad Cr-Commit-Position: refs/heads/master@{#354367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -6 lines) Patch
M build/android/devil/android/device_temp_file.py View 2 chunks +16 lines, -6 lines 0 comments Download
A build/android/devil/android/device_temp_file_test.py View 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark P
Created Revert of Android: Trust large random numbers for temp files
5 years, 2 months ago (2015-10-15 21:36:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412433003/1
5 years, 2 months ago (2015-10-15 21:39:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 21:40:36 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/011b0059489c76c8ef45456ef8131217398c4fad Cr-Commit-Position: refs/heads/master@{#354367}
5 years, 2 months ago (2015-10-15 21:42:01 UTC) #4
agrieve
5 years, 2 months ago (2015-10-16 00:49:23 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1410553004/ by agrieve@chromium.org.

The reason for reverting is: Relanding with fix for ReadFile(as_root=True).

Powered by Google App Engine
This is Rietveld 408576698