Issue 141243006: Make element.style.setProperty override earlier property values

Issue 141243006: Make element.style.setProperty override earlier property values (Closed)

Created:
6 years, 10 months ago by rwlbuis

Modified:
6 years ago

Reviewers:
esprehn

CC:
blink-reviews, arv+blink, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, watchdog-blink-watchlist_google.com, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Make element.style.setProperty override earlier property values When using setProperty make sure any previous value for the parsed property is overridden. Also follow CSSOM more strictly and bail out if the priority is not "important" or empty. BUG=331236

Patch Set 1 #

Patch Set 2 : Do strict important check #

Patch Set 3 : Use a temp property set #

Patch Set 4 : Set correct parser mode #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -4 lines)			Patch
M	LayoutTests/fast/css/shorthand-priority.html	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	LayoutTests/fast/css/shorthand-priority-expected.txt	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSStyleDeclaration.idl	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/PropertySetCSSStyleDeclaration.cpp	View	1 2 3	1 chunk	+12 lines, -2 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rwlbuis

PTAL. This way implements the behavior described in the CSSOM spec and matches FF. Another ...

6 years, 10 months ago (2014-02-20 16:48:52 UTC) #1

esprehn

https://codereview.chromium.org/141243006/diff/140001/Source/core/css/PropertySetCSSStyleDeclaration.cpp File Source/core/css/PropertySetCSSStyleDeclaration.cpp (right): https://codereview.chromium.org/141243006/diff/140001/Source/core/css/PropertySetCSSStyleDeclaration.cpp#newcode220 Source/core/css/PropertySetCSSStyleDeclaration.cpp:220: return; Can you make this change separately? https://codereview.chromium.org/141243006/diff/140001/Source/core/css/PropertySetCSSStyleDeclaration.cpp#newcode229 Source/core/css/PropertySetCSSStyleDeclaration.cpp:229: ...

6 years, 10 months ago (2014-02-25 19:20:39 UTC) #2

rwlbuis

On 2014/02/25 19:20:39, esprehn wrote: > https://codereview.chromium.org/141243006/diff/140001/Source/core/css/PropertySetCSSStyleDeclaration.cpp > File Source/core/css/PropertySetCSSStyleDeclaration.cpp (right): > > https://codereview.chromium.org/141243006/diff/140001/Source/core/css/PropertySetCSSStyleDeclaration.cpp#newcode220 > ...

6 years, 10 months ago (2014-02-25 21:34:51 UTC) #3

rwlbuis

6 years, 9 months ago (2014-03-07 19:33:00 UTC) #5

On 2014/03/07 18:43:52, esprehn wrote:
> Any progress on the rest of this patch?

No, I have been doing some stuff that has more higher priority for now. I still
plan to look at this at some point.

Expand Messages | Collapse Messages