Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: media/filters/audio_renderer_impl.h

Issue 141243003: Add AudioBufferStream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@decoderstream_rebased
Patch Set: address comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/audio_renderer_impl.h
diff --git a/media/filters/audio_renderer_impl.h b/media/filters/audio_renderer_impl.h
index 2617bdd87421cc1f1ee7bd17097b78413167a9b7..b5e0efed983b963ee849e270df7d0c37c049d1fb 100644
--- a/media/filters/audio_renderer_impl.h
+++ b/media/filters/audio_renderer_impl.h
@@ -29,7 +29,7 @@
#include "media/base/audio_renderer_sink.h"
#include "media/base/decryptor.h"
#include "media/filters/audio_renderer_algorithm.h"
-#include "media/filters/decoder_selector.h"
+#include "media/filters/decoder_stream.h"
namespace base {
class SingleThreadTaskRunner;
@@ -108,7 +108,7 @@ class MEDIA_EXPORT AudioRendererImpl
};
// Callback from the audio decoder delivering decoded audio samples.
- void DecodedAudioReady(AudioDecoder::Status status,
+ void DecodedAudioReady(AudioBufferStream::Status status,
const scoped_refptr<AudioBuffer>& buffer);
// Handles buffers that come out of |splicer_|.
@@ -164,14 +164,9 @@ class MEDIA_EXPORT AudioRendererImpl
// in the kPrerolling state.
bool IsBeforePrerollTime(const scoped_refptr<AudioBuffer>& buffer);
- // Called when |decoder_selector_| has selected |decoder| or is null if no
- // decoder could be selected.
- //
- // |decrypting_demuxer_stream| is non-null if a DecryptingDemuxerStream was
- // created to help decrypt the encrypted stream.
- void OnDecoderSelected(
- scoped_ptr<AudioDecoder> decoder,
- scoped_ptr<DecryptingDemuxerStream> decrypting_demuxer_stream);
+ // Called upon AudioBufferStream initialization, or failure thereof (indicated
+ // by the value of |success|).
+ void OnAudioBufferStreamInitialized(bool succes);
// Used to initiate the flush operation once all pending reads have
// completed.
@@ -198,18 +193,13 @@ class MEDIA_EXPORT AudioRendererImpl
// may deadlock between |task_runner_| and the audio callback thread.
scoped_refptr<media::AudioRendererSink> sink_;
- scoped_ptr<AudioDecoderSelector> decoder_selector_;
-
- // These two will be set by AudioDecoderSelector::SelectAudioDecoder().
- scoped_ptr<AudioDecoder> decoder_;
- scoped_ptr<DecryptingDemuxerStream> decrypting_demuxer_stream_;
+ AudioBufferStream audio_buffer_stream_;
- // AudioParameters constructed during Initialize() based on |decoder_|.
+ // AudioParameters constructed during Initialize().
AudioParameters audio_parameters_;
// Callbacks provided during Initialize().
PipelineStatusCB init_cb_;
- StatisticsCB statistics_cb_;
base::Closure underflow_cb_;
TimeCB time_cb_;
base::Closure ended_cb_;
@@ -219,9 +209,6 @@ class MEDIA_EXPORT AudioRendererImpl
// Callback provided to Flush().
base::Closure flush_cb_;
- // Callback provided to Stop().
- base::Closure stop_cb_;
-
// Callback provided to Preroll().
PipelineStatusCB preroll_cb_;

Powered by Google App Engine
This is Rietveld 408576698