Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 141243002: Fix an issue that MediaController is disaled when entering fullscreen (Closed)

Created:
6 years, 11 months ago by qinmin
Modified:
6 years, 11 months ago
Reviewers:
Ted C, trchen
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix an issue that MediaController is disaled when entering fullscreen In the old contentVideoView.java, we create the MediaController first in the openVideo() call. Then we call updateMediaMetadata() to enable to media controller and set the metadata. With ContentVideoViewLegacy.java, the ordering between updateMediaMetadata() and mediaController creation is reversed. That causes the controller to become disabled. This change posts a task when RequestMediaMetadata() is called to solve the above issue, and to avoid the reentrance issue. BUG=334635 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245376

Patch Set 1 #

Total comments: 1

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M content/browser/android/content_video_view.h View 1 3 chunks +5 lines, -1 line 0 comments Download
M content/browser/android/content_video_view.cc View 1 4 chunks +18 lines, -10 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
qinmin
PTAL
6 years, 11 months ago (2014-01-16 21:39:36 UTC) #1
Ted C
lgtm https://codereview.chromium.org/141243002/diff/1/content/browser/android/content_video_view.h File content/browser/android/content_video_view.h (right): https://codereview.chromium.org/141243002/diff/1/content/browser/android/content_video_view.h#newcode112 content/browser/android/content_video_view.h:112: base::WeakPtrFactory<ContentVideoView> weak_this_; weak_factory_ is much more common (~452 ...
6 years, 11 months ago (2014-01-16 21:45:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/141243002/60001
6 years, 11 months ago (2014-01-16 21:58:28 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 23:41:57 UTC) #4
Message was sent while issue was closed.
Change committed as 245376

Powered by Google App Engine
This is Rietveld 408576698