add logging code to track unexpected situation - fixes #24630

add logging code to track unexpected situation - fixes #24630

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/f45c8bc91785195f6c440f2045bbafda173b763a

[danrubel, 2015-10-22 16:25:03]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-10-22 16:26:33]

https://codereview.chromium.org/1412423006/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
(right):

https://codereview.chromium.org/1412423006/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:19:
import 'package:analyzer/src/generated/engine.dart' as engine;
sort?

https://codereview.chromium.org/1412423006/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:443:
.logInformation('Completion expected resolved AST');
Maybe we should include name of the source, if it's accessible.

[danrubel, 2015-10-22 16:50:52]

Comments addressed. PTAL

https://codereview.chromium.org/1412423006/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
(right):

https://codereview.chromium.org/1412423006/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:19:
import 'package:analyzer/src/generated/engine.dart' as engine;
On 2015/10/22 16:26:33, scheglov wrote:
> sort?

Good point. Done.

https://codereview.chromium.org/1412423006/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:443:
.logInformation('Completion expected resolved AST');
On 2015/10/22 16:26:33, scheglov wrote:
> Maybe we should include name of the source, if it's accessible.

There is a lot of additional information that would be useful here including the
source, but all of it, including file name, offset, actual source code on which
the completion request was made, etc. is available as part of the log.

[scheglov, 2015-10-22 17:05:50]

lgtm

[danrubel, 2015-10-22 17:07:03]

Committed patchset #2 (id:20001) manually as
f45c8bc91785195f6c440f2045bbafda173b763a (presubmit successful).